From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 835F52B96 for ; Sun, 21 Jan 2018 23:40:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2018 14:40:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,393,1511856000"; d="scan'208";a="21470800" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.1.152]) ([10.252.1.152]) by FMSMGA003.fm.intel.com with ESMTP; 21 Jan 2018 14:40:42 -0800 To: Thomas Monjalon , dev@dpdk.org Cc: Pavan Nikhilesh References: <20180121222135.26160-1-thomas@monjalon.net> <7525503.S6sahj4VeJ@xps> From: Ferruh Yigit Message-ID: Date: Sun, 21 Jan 2018 22:40:42 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <7525503.S6sahj4VeJ@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] examples/eventdev: fix build with GCC < 5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Jan 2018 22:40:45 -0000 On 1/21/2018 10:32 PM, Thomas Monjalon wrote: > Forgot the Fixes: tags, > > 21/01/2018 23:21, Thomas Monjalon: >> Some errors were seen with GCC 4.8 and 4.9. >> It looks to be a bug fixed in GCC 5. >> >> examples/eventdev_pipeline/pipeline_worker_generic.c:474:4: error: >> missing initializer for field 'queue_id' of 'struct ' >> >> examples/eventdev_pipeline/pipeline_worker_generic.c:475:3: error: >> missing initializer for field 'priority' of 'struct ' >> >> examples/eventdev_pipeline/pipeline_worker_tx.c:630:2: error: >> missing initializer for field 'queue_id' of 'struct ' >> >> The workaround is to not use initializer statement, >> but to use memset and standard assignment. > > Fixes: 84dde5de10a2 ("examples/eventdev: support Rx adapter") > Fixes: fa8054c8c889 ("examples/eventdev: add thread safe Tx worker pipeline") > >> Signed-off-by: Thomas Monjalon Reviewed-by: Ferruh Yigit