From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Kaiwen Deng <kaiwenx.deng@intel.com>,
dev@dpdk.org, Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,
Declan Doherty <declan.doherty@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/bonding: fix forward packets failed
Date: Fri, 10 Mar 2023 21:11:47 +0000 [thread overview]
Message-ID: <efac4b30-a269-5e9d-7469-15fb3d7c4e82@amd.com> (raw)
In-Reply-To: <20230310044131.2052540-1-kaiwenx.deng@intel.com>
On 3/10/2023 4:41 AM, Kaiwen Deng wrote:
> The bond port is failed to forward packets in Link Aggregation
> 802.3AD(4) mode. Because bond devices get LACP packets from
> rx_ring instead of tx_ring.
>
> This commit will get LACP packets from tx_ring instead.
>
> Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP control")
> Cc: stable@dpdk.org
>
Fixes commit is from 2017, was 802.3AD mode broken since that time?
Or is this for a specific use case?
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index 4a266bb2ca..b585752b00 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -941,7 +941,7 @@ bond_mode_8023ad_periodic_cb(void *arg)
> /* Find LACP packet to this port. Do not check subtype,
> * it is done in function that queued packet
> */
> - int retval = rte_ring_dequeue(port->rx_ring,
> + int retval = rte_ring_dequeue(port->tx_ring,
> (void **)&lacp_pkt);
>
> if (retval != 0)
prev parent reply other threads:[~2023-03-10 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 4:41 Kaiwen Deng
2023-03-10 9:59 ` Jiale, SongX
2023-03-10 21:11 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efac4b30-a269-5e9d-7469-15fb3d7c4e82@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chas3@att.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=kaiwenx.deng@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=tomaszx.kulasek@intel.com \
--cc=yidingx.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).