From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 321F0A04BC; Thu, 8 Oct 2020 12:07:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 45CDA1BD7D; Thu, 8 Oct 2020 12:07:21 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id 874641BD6E for ; Thu, 8 Oct 2020 12:07:19 +0200 (CEST) Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id D000A9FECC9D43836283; Thu, 8 Oct 2020 18:07:14 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Thu, 8 Oct 2020 18:07:09 +0800 From: "Min Hu (Connor)" To: Ferruh Yigit , dev CC: thomas , Linuxarm , konstantin.ananyev , arybchenko References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1601341419-15870-1-git-send-email-humin29@huawei.com> <1601341419-15870-4-git-send-email-humin29@huawei.com> <27557195-5b72-9db5-f1b2-924139243b37@intel.com> <5414371e-4d5c-0b55-8a5b-72773d98b2f7@intel.com> Message-ID: Date: Thu, 8 Oct 2020 18:06:59 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <5414371e-4d5c-0b55-8a5b-72773d98b2f7@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH V15 3/3] app/testpmd: add FEC command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Ferruh, I have sent patches of new version named V16. Please check it out, thanks. 在 2020/10/8 7:38, humin (Q) 写道: > HI，Ferry, > >      thank you very much. this is good news to me. I promise the new > version will be sent in these two days. > >       thanks again. > > -------------------------------------------------- > 胡敏 Hu Min > Mobile: +86-13528728164 > Email: humin29@huawei.com > > *发件人：*Ferruh Yigit > *收件人：*humin (Q) ;dev > *抄 送：*konstantin.ananyev ;thomas > ;arybchenko ;Linuxarm > > *时 间：*2020-10-07 17:30:09 > *主 题：*Re: [PATCH V15 3/3] app/testpmd: add FEC command > > On 10/7/2020 1:15 AM, humin (Q) wrote: >> HI，Ferruh, >> >>       how about only considering the first patch:ethdev:add fec API. If this >> patch looks great to you, I wish it could be merged into 20.11. >> >>        To that patch, app/testpmd add fec command, I will fix it later. > > Hi Connor, > > Better to get them together if possible, -rc1 has been postponed to > October 16, > can this additional week help to get a new version? > > >> >>        thanks. >> >> -------------------------------------------------- >> 胡敏 Hu Min >> Mobile: +86-13528728164 >> Email: humin29@huawei.com >> >> *发件人：*Ferruh Yigit >> *收件人：*humin (Q) ;dev >> *抄 送：*konstantin.ananyev ;thomas >> ;arybchenko ;Linuxarm >> >> *时 间：*2020-10-01 00:53:37 >> *主 题：*Re: [PATCH V15 3/3] app/testpmd: add FEC command >> >> On 9/29/2020 2:03 AM, Min Hu (Connor) wrote: >>> This commit adds testpmd capability to query and config FEC >>> function of device. This includes: >>> - show FEC capabilities, example: >>>        testpmd> show port 0 fec capabilities >>> - show FEC mode, example: >>>        testpmd> show port 0 fec_mode >>> - config FEC mode, example: >>>        testpmd> set port 0 >>> >> >> I guess it is: >> set port fec_mode >> >>>        where: >>> >>>        auto|off|rs|baser are four kinds of FEC mode which dev >>>        support according to MAC link speed. >>> >>> Signed-off-by: Min Hu (Connor) >>> Reviewed-by: Wei Hu (Xavier) >>> Reviewed-by: Chengwen Feng >>> Reviewed-by: Chengchang Tang >>> --- >>> v12->v13: >>> change fec get capa interface. >>> >>> --- >>> v10->v11: >>> change mode to capa bitmask. >>> >>> --- >>> v8->v9: >>> added acked-by. >>> >>> --- >>> v6->v7: >>> used RTE_DIM(fec_mode_name) instead of RTE_ETH_FEC_NUM >>> >>> --- >>> v5->v6: >>> fixed code styles according to DPDK coding style. >>> added _eth prefix. >>> >>> --- >>> v4->v5: >>> Add RTE_ prefix for public FEC mode enum. >>> >>> --- >>> v3->v4: >>> adjust the display format of FEC mode >>> >>> --- >>> v2->v3: >>> adjust the display format of FEC capability. >>> >>> --- >>>   app/test-pmd/cmdline.c | 223 +++++++++++++++++++++++++++++++++++++++++++++++++ >>>   app/test-pmd/config.c  |  91 ++++++++++++++++++++ >>>   app/test-pmd/testpmd.h |   2 + >>>   3 files changed, 316 insertions(+) >> >> Can you please update the testpmd documenatation for the new commands? >> >> Also can add the new command to the --help output? ('cmd_help_long_parsed()') >> >> <...> >> >>> +cmdline_parse_inst_t cmd_set_fec_mode = { >>> +     .f = cmd_set_port_fec_mode_parsed, >>> +     .data = NULL, >>> +     .help_str = "set port fec_mode ", >> >> Can you please update the help string as: >> "set port fec_mode auto|off|rs|baser" >> >> '<>' is to define the variable name, like in '' you expect numbers like >> 0,1,2 .. but 'auto|off|rs|baser' are keywords, not variables. > > > _______________________________________________ > Linuxarm mailing list > Linuxarm@huawei.com > http://hulk.huawei.com/mailman/listinfo/linuxarm >