Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

[Pascal Mazon <pascal.mazon@6wind.com>]

Hi,

I'm surprised there's only one place in the file with indent problem,
but I'm ok with the patch otherwise.

Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in
patch 2/2, right?

Best regards,
Pascal

On 04/10/2017 00:07, Ferruh Yigit wrote:
> On 10/3/2017 3:55 PM, Matan Azrad wrote:
>> Missed 4 spaces were added after break if line.
>>
>> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands")
> What do you think fixing this when that code has been touched next time?
>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
>> ---
>>  drivers/net/tap/tap_flow.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c
>> index eefa868..aa33960 100644
>> --- a/drivers/net/tap/tap_flow.c
>> +++ b/drivers/net/tap/tap_flow.c
>> @@ -1093,7 +1093,7 @@ struct tap_flow_items {
>>  				goto exit_action_not_supported;
>>  			action = 1;
>>  			if (!queue ||
>> -			(queue->index > pmd->dev->data->nb_rx_queues - 1))
>> +			    (queue->index > pmd->dev->data->nb_rx_queues - 1))
>>  				goto exit_action_not_supported;
>>  			if (flow)
>>  				err = add_action_skbedit(flow, queue->index);
>>