From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id BE53D2661 for ; Wed, 4 Oct 2017 10:15:44 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id q124so21175176wmb.0 for ; Wed, 04 Oct 2017 01:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=XfDClHhCAitbIUpA1EAmP7KEOqfTUPgouD4naXtHa5A=; b=HXyGKMOw37+S5H3uxdthlFW37pCFWq7GCvYki9bpTMlmNV7h9k4S5vXKryY1IxdUn4 23lI/D1NuGTwS8SKQPDJ3tDknJKq2FQjJg/jPmwOmts1MzVDH1Iqg41mPQBAvtWXrBG8 x0cg1Lz2f4afJdN8hTGYY3cJ/9wKUnZfIrukAIx49s/l8mYOsOUXlD+1ZoYO7Mox82hl 9y8zj1ezdsehd4Uh6nC6logEJwecQw30LwY4exUCFVSP/6fOqt7vHg++zHH+/zkCT3c5 XtBOzEZMdXZGS60mqDXp2yAaZtiiWsWEtXPRT8kqs8wynGYI2nPR30rzLD1KuxZsC2Ga W+eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=XfDClHhCAitbIUpA1EAmP7KEOqfTUPgouD4naXtHa5A=; b=YMv1Xs5VjeArwJsntEJqJ3S+wxLMa9px+/ggRsoVFsaSQAr8+pWuz6gTbqTpPk1ytM 5cLAhFhPoqC6ohzE19PKX5cF7cyLVhSIuK57XdWkJVLjKBj0Hr1KIztzZqsRgp9QYvq2 w8c55a+lGMYyZEVl1IeaF73rRzFen4jSHh2vfPuMw43QLGqANSqELcbgOdx/5Or/3mID 68+DsEP+M8b50s/PD3KYmvyxwnpQ7Ovod0NTnoMKodKMVUUOI1pH9WZsnCRvkwUuQOLa 0DeVAsjY5LBwTYfOWGGe2u05Tcl9ryBj/FuxLd0Myc6B3x0Jur9e4Y0Hv4UXiY3OeTZ8 8DXQ== X-Gm-Message-State: AHPjjUgwIp8zsFFxBRm8SirtBEh5q2Fkhhblsj8IO7Ib9rHX1thSiNtz o9+7AYmifIHcjzgPtrAc/wrkJeMStv4= X-Google-Smtp-Source: AOwi7QBmMr/D6sZ7fr600BUq1kpq2YV52ILIU1fS451uyxo9WkzgW376F2KKPtXJOToPfoSwMeLAEg== X-Received: by 10.80.181.194 with SMTP id a60mr26578455ede.231.1507104944035; Wed, 04 Oct 2017 01:15:44 -0700 (PDT) Received: from [10.16.18.139] (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p37sm12096150eda.22.2017.10.04.01.15.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 04 Oct 2017 01:15:43 -0700 (PDT) To: Ferruh Yigit , Matan Azrad Cc: dev@dpdk.org References: <1507042556-9839-1-git-send-email-matan@mellanox.com> <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> From: Pascal Mazon Message-ID: Date: Wed, 4 Oct 2017 10:15:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <551c25bb-5888-00d0-30a5-0d3a0964132d@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Oct 2017 08:15:44 -0000 Hi, I'm surprised there's only one place in the file with indent problem, but I'm ok with the patch otherwise. Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in patch 2/2, right? Best regards, Pascal On 04/10/2017 00:07, Ferruh Yigit wrote: > On 10/3/2017 3:55 PM, Matan Azrad wrote: >> Missed 4 spaces were added after break if line. >> >> Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") > What do you think fixing this when that code has been touched next time? > >> Signed-off-by: Matan Azrad >> --- >> drivers/net/tap/tap_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c >> index eefa868..aa33960 100644 >> --- a/drivers/net/tap/tap_flow.c >> +++ b/drivers/net/tap/tap_flow.c >> @@ -1093,7 +1093,7 @@ struct tap_flow_items { >> goto exit_action_not_supported; >> action = 1; >> if (!queue || >> - (queue->index > pmd->dev->data->nb_rx_queues - 1)) >> + (queue->index > pmd->dev->data->nb_rx_queues - 1)) >> goto exit_action_not_supported; >> if (flow) >> err = add_action_skbedit(flow, queue->index); >>