From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id E76B04C9F; Fri, 5 Oct 2018 10:55:28 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Oct 2018 01:55:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,343,1534834800"; d="scan'208";a="78693226" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by orsmga007.jf.intel.com with ESMTP; 05 Oct 2018 01:55:25 -0700 To: Nikhil Rao , Jerin Jacob Cc: dev@dpdk.org, stable@dpdk.org, sunila.sahu@caviumnetworks.com, rasesh.mody@cavium.com, roy.fan.zhang@intel.com References: <20181003134811.64662-1-ferruh.yigit@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Fri, 5 Oct 2018 09:55:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181003134811.64662-1-ferruh.yigit@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eventdev: prefix global variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Oct 2018 08:55:29 -0000 On 10/3/2018 2:48 PM, Ferruh Yigit wrote: > A global defined with name "stats". > > DPDK is a library, please don't define global variables with this > generic name. > > Fixes: b1ce8ebd97ba ("eventdev: add PMD callbacks for eth Rx adapter") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > There are already questions about that "stats" variable: > - Why a global variable defined in header file? > - It seems it is not used at all, remove it? > Forgotten to be removed in below commit, but because of generic > "stats" name, it didn't cause any compile error but happily used > global variable > Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") > > But this patch mainly sent as an RFC, to ask what would you think about > a cleanup patch to add the library prefix for all the global variables > that are defined in libries? (yes we have lots of them) > > Like: > zip_cc --> octeontx_zip_cc [1] > valid_args --> qede_valid_args [2] > scheduler --> crypto_scheduler [3] The cleanup patch has been sent: "fix static variables" https://patches.dpdk.org/patch/46006/ This patch has been superseded by above one.