From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3B73EA0A05; Tue, 19 Jan 2021 15:52:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61E8F140EC0; Tue, 19 Jan 2021 15:51:59 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 8CB38140EB6; Tue, 19 Jan 2021 15:51:57 +0100 (CET) IronPort-SDR: CI/ey+hEv+E/ipArDUiRb4tCuLq2UTOOnwVsD/C1gCbThQLDdNG24yFgV7a/ttG7KElPut6MJf Us/IerHjhi9w== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="166602362" X-IronPort-AV: E=Sophos;i="5.79,359,1602572400"; d="scan'208";a="166602362" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 06:51:50 -0800 IronPort-SDR: 3U1ClNaER75DKfF5wj5wrpK3yl68gIEFfqJqGDOSR2U76XXuWeuJkUwOuLnDqGwag2FYaoiFT0 SvZr1MyAdzvA== X-IronPort-AV: E=Sophos;i="5.79,359,1602572400"; d="scan'208";a="383963059" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.225.7]) ([10.213.225.7]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 06:51:48 -0800 To: Thomas Monjalon , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, anatoly.burakov@intel.com References: <20201217113656.28884-1-david.hunt@intel.com> <20210108143048.23755-1-david.hunt@intel.com> <20210108143048.23755-3-david.hunt@intel.com> <5259190.4FFyF7rmBE@thomas> From: David Hunt Message-ID: Date: Tue, 19 Jan 2021 14:51:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <5259190.4FFyF7rmBE@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 2/6] power: make channel msg functions public X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19/1/2021 2:31 PM, Thomas Monjalon wrote: > 08/01/2021 15:30, David Hunt: >> From: Bruce Richardson >> >> Move the 2 public functions into rte_power_guest_channel.h > [...] >> +/** >> + * Send a message contained in pkt over the Virtio-Serial to the host endpoint. >> + * >> + * @param pkt >> + * Pointer to a populated struct channel_packet >> + * >> + * @param lcore_id >> + * lcore_id. >> + * >> + * @return >> + * - 0 on success. >> + * - Negative on error. >> + */ >> +int rte_power_guest_channel_send_msg(struct channel_packet *pkt, >> + unsigned int lcore_id); >> + >> +/** >> + * Receive a message contained in pkt over the Virtio-Serial >> + * from the host endpoint. >> + * >> + * @param pkt >> + * Pointer to channel_packet or >> + * channel_packet_freq_list struct. >> + * >> + * @param pkt_len >> + * Size of expected data packet. >> + * >> + * @param lcore_id >> + * lcore_id. >> + * >> + * @return >> + * - 0 on success. >> + * - Negative on error. >> + */ >> +__rte_experimental >> +int >> +rte_power_guest_channel_receive_msg(void *pkt, >> + size_t pkt_len, >> + unsigned int lcore_id); > Why only the second one is experimental? > > Given the uncertainty of this API, I think it should be all experimental. > Yes Thomas, both should be experimental. I'll fix that in the next version. Thanks, Dave.