From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 7AF1A7CDA for ; Tue, 25 Sep 2018 13:36:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2018 04:36:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,301,1534834800"; d="scan'208";a="89154286" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga002.fm.intel.com with ESMTP; 25 Sep 2018 04:35:46 -0700 To: Ajit Khaparde , dev@dpdk.org References: <20180922045559.27438-1-ajit.khaparde@broadcom.com> <20180922045559.27438-13-ajit.khaparde@broadcom.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: Date: Tue, 25 Sep 2018 12:35:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180922045559.27438-13-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 12/12] net/bnxt: remove excess log messages X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Sep 2018 11:36:42 -0000 On 9/22/2018 5:55 AM, Ajit Khaparde wrote: > When the firmware version and the driver HWRM version do not match, > we are logging some messages. These messages unnecessarily clutter > the logs and can add to the noise. We are logging the HWRM version > and the firmware version anyway. The difference in version numbers > can be gleaned from that. Removing the remaining log messages. If these messages are creating noise, wouldn't you want this patch to be backported to stable tree? If so can you please update commit log? > > Signed-off-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 20 -------------------- > 1 file changed, 20 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 38698e214..76e443ec1 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -789,7 +789,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp) > int rc = 0; > struct hwrm_ver_get_input req = {.req_type = 0 }; > struct hwrm_ver_get_output *resp = bp->hwrm_cmd_resp_addr; > - uint32_t my_version; > uint32_t fw_version; > uint16_t max_resp_len; > char type[RTE_MEMZONE_NAMESIZE]; > @@ -817,10 +816,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp) > PMD_DRV_LOG(INFO, "Driver HWRM version: %d.%d.%d\n", > HWRM_VERSION_MAJOR, HWRM_VERSION_MINOR, HWRM_VERSION_UPDATE); > > - my_version = HWRM_VERSION_MAJOR << 16; > - my_version |= HWRM_VERSION_MINOR << 8; > - my_version |= HWRM_VERSION_UPDATE; > - > fw_version = resp->hwrm_intf_maj_8b << 16; > fw_version |= resp->hwrm_intf_min_8b << 8; > fw_version |= resp->hwrm_intf_upd_8b; > @@ -832,21 +827,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp) > goto error; > } > > - if (my_version != fw_version) { > - PMD_DRV_LOG(INFO, "BNXT Driver/HWRM API mismatch.\n"); > - if (my_version < fw_version) { > - PMD_DRV_LOG(INFO, > - "Firmware API version is newer than driver.\n"); > - PMD_DRV_LOG(INFO, > - "The driver may be missing features.\n"); > - } else { > - PMD_DRV_LOG(INFO, > - "Firmware API version is older than driver.\n"); > - PMD_DRV_LOG(INFO, > - "Not all driver features may be functional.\n"); > - } > - } > - > if (bp->max_req_len > resp->max_req_win_len) { > PMD_DRV_LOG(ERR, "Unsupported request length\n"); > rc = -EINVAL; >