* [PATCH] net/dpaa2: set check sum good flags
@ 2023-05-08 10:57 Tianli Lai
2023-05-10 5:39 ` Sachin Saxena (OSS)
2023-05-10 5:50 ` Sachin Saxena (OSS)
0 siblings, 2 replies; 4+ messages in thread
From: Tianli Lai @ 2023-05-08 10:57 UTC (permalink / raw)
To: dev; +Cc: Hemant Agrawal, Sachin Saxena
set check sum good flags when dpaa2 hardware set check result.
Signed-off-by: Tianli Lai <laitianli@tom.com>
---
drivers/net/dpaa2/dpaa2_rxtx.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c
index f60e78e1fd..85910bbd8f 100644
--- a/drivers/net/dpaa2/dpaa2_rxtx.c
+++ b/drivers/net/dpaa2/dpaa2_rxtx.c
@@ -198,8 +198,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf,
if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
- else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
+ else
+ mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+ if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+ else
+ mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT |
L3_IP_1_MORE_FRAGMENT |
@@ -241,8 +245,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr)
if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
- else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
+ else
+ mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
+ if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
+ else
+ mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
if (dpaa2_enable_ts[mbuf->port]) {
*dpaa2_timestamp_dynfield(mbuf) = annotation->word2;
--
2.27.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/dpaa2: set check sum good flags
2023-05-08 10:57 [PATCH] net/dpaa2: set check sum good flags Tianli Lai
@ 2023-05-10 5:39 ` Sachin Saxena (OSS)
2023-05-10 5:50 ` Sachin Saxena (OSS)
1 sibling, 0 replies; 4+ messages in thread
From: Sachin Saxena (OSS) @ 2023-05-10 5:39 UTC (permalink / raw)
To: Tianli Lai, dev; +Cc: Hemant Agrawal, Sachin Saxena
On 5/8/2023 4:27 PM, Tianli Lai wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> set check sum good flags when dpaa2 hardware set check result.
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
> drivers/net/dpaa2/dpaa2_rxtx.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c
> index f60e78e1fd..85910bbd8f 100644
> --- a/drivers/net/dpaa2/dpaa2_rxtx.c
> +++ b/drivers/net/dpaa2/dpaa2_rxtx.c
> @@ -198,8 +198,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf,
>
> if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
> - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
> + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
>
> if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT |
> L3_IP_1_MORE_FRAGMENT |
> @@ -241,8 +245,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr)
>
> if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
> - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
> + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
>
> if (dpaa2_enable_ts[mbuf->port]) {
> *dpaa2_timestamp_dynfield(mbuf) = annotation->word2;
> --
> 2.27.0
>
Acked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
--
Thanks,
Sachin Saxena
(NXP)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/dpaa2: set check sum good flags
2023-05-08 10:57 [PATCH] net/dpaa2: set check sum good flags Tianli Lai
2023-05-10 5:39 ` Sachin Saxena (OSS)
@ 2023-05-10 5:50 ` Sachin Saxena (OSS)
2023-05-12 11:24 ` Ferruh Yigit
1 sibling, 1 reply; 4+ messages in thread
From: Sachin Saxena (OSS) @ 2023-05-10 5:50 UTC (permalink / raw)
To: Tianli Lai, dev, Sachin Saxena; +Cc: Hemant Agrawal
On 5/8/2023 4:27 PM, Tianli Lai wrote:
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> set check sum good flags when dpaa2 hardware set check result.
>
> Signed-off-by: Tianli Lai <laitianli@tom.com>
> ---
> drivers/net/dpaa2/dpaa2_rxtx.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/dpaa2/dpaa2_rxtx.c
> index f60e78e1fd..85910bbd8f 100644
> --- a/drivers/net/dpaa2/dpaa2_rxtx.c
> +++ b/drivers/net/dpaa2/dpaa2_rxtx.c
> @@ -198,8 +198,12 @@ dpaa2_dev_rx_parse_slow(struct rte_mbuf *mbuf,
>
> if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
> - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
> + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
>
> if (BIT_ISSET_AT_POS(annotation->word4, L3_IP_1_FIRST_FRAGMENT |
> L3_IP_1_MORE_FRAGMENT |
> @@ -241,8 +245,12 @@ dpaa2_dev_rx_parse(struct rte_mbuf *mbuf, void *hw_annot_addr)
>
> if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L3CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_BAD;
> - else if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_IP_CKSUM_GOOD;
> + if (BIT_ISSET_AT_POS(annotation->word8, DPAA2_ETH_FAS_L4CE))
> mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD;
> + else
> + mbuf->ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD;
>
> if (dpaa2_enable_ts[mbuf->port]) {
> *dpaa2_timestamp_dynfield(mbuf) = annotation->word2;
> --
> 2.27.0
>
Acked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
--
Thanks,
Sachin Saxena
(NXP)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/dpaa2: set check sum good flags
2023-05-10 5:50 ` Sachin Saxena (OSS)
@ 2023-05-12 11:24 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2023-05-12 11:24 UTC (permalink / raw)
To: Sachin Saxena (OSS), Tianli Lai, dev, Sachin Saxena; +Cc: Hemant Agrawal
On 5/10/2023 6:50 AM, Sachin Saxena (OSS) wrote:
> On 5/8/2023 4:27 PM, Tianli Lai wrote:
>> Caution: This is an external email. Please take care when clicking
>> links or opening attachments. When in doubt, report the message using
>> the 'Report this email' button
>>
>>
>> set check sum good flags when dpaa2 hardware set check result.
>>
>> Signed-off-by: Tianli Lai <laitianli@tom.com>
>
> Acked-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
>
Fixes: d2ef05d5c13e ("net/dpaa2: optimize Rx/Tx path")
Fixes: 94d31549c380 ("net/dpaa2: support Rx checksum offload in slow
parsing")
Cc: stable@dpdk.org
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-12 11:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-08 10:57 [PATCH] net/dpaa2: set check sum good flags Tianli Lai
2023-05-10 5:39 ` Sachin Saxena (OSS)
2023-05-10 5:50 ` Sachin Saxena (OSS)
2023-05-12 11:24 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).