* [dpdk-dev] [PATCH] net/cxgbe: avoid sending link params change from VF
@ 2021-09-27 17:56 Rahul Lakkireddy
2021-09-30 15:45 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Lakkireddy @ 2021-09-27 17:56 UTC (permalink / raw)
To: dev; +Cc: nikhil.vasoya, stable
From: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
VFs are not allowed to change physical link params when a port
module change is detected. The firmware already returns appropriate
permission error when VF tries to change physical link params. But,
make sure to avoid sending the command to firmware from VF in the
first place and prevent flooding firmware debug logs with permission
errors.
Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
Cc: stable@dpdk.org
Signed-off-by: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/cxgbe/base/t4_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cxgbe/base/t4_hw.c b/drivers/net/cxgbe/base/t4_hw.c
index b60bcdc3bc..cdcd7e5510 100644
--- a/drivers/net/cxgbe/base/t4_hw.c
+++ b/drivers/net/cxgbe/base/t4_hw.c
@@ -4597,7 +4597,7 @@ static void t4_handle_get_port_info(struct port_info *pi, const __be64 *rpl)
t4_os_link_changed(adapter, pi->pidx);
}
- if (mod_changed) {
+ if (mod_changed != 0 && is_pf4(adapter) != 0) {
u32 mod_caps = lc->admin_caps;
int ret;
--
2.27.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/cxgbe: avoid sending link params change from VF
2021-09-27 17:56 [dpdk-dev] [PATCH] net/cxgbe: avoid sending link params change from VF Rahul Lakkireddy
@ 2021-09-30 15:45 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-09-30 15:45 UTC (permalink / raw)
To: Rahul Lakkireddy, dev; +Cc: nikhil.vasoya, stable
On 9/27/2021 6:56 PM, Rahul Lakkireddy wrote:
> From: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
>
> VFs are not allowed to change physical link params when a port
> module change is detected. The firmware already returns appropriate
> permission error when VF tries to change physical link params. But,
> make sure to avoid sending the command to firmware from VF in the
> first place and prevent flooding firmware debug logs with permission
> errors.
>
> Fixes: a83041b1e998 ("net/cxgbe: rework and simplify link handling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Nikhil Vasoya <nikhil.vasoya@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-30 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-27 17:56 [dpdk-dev] [PATCH] net/cxgbe: avoid sending link params change from VF Rahul Lakkireddy
2021-09-30 15:45 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).