From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 9B76F1041; Wed, 19 Sep 2018 11:21:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Sep 2018 02:21:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,393,1531810800"; d="scan'208";a="91847080" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.28.16]) ([10.252.28.16]) by orsmga001.jf.intel.com with ESMTP; 19 Sep 2018 02:21:36 -0700 From: Ferruh Yigit To: Ajit Khaparde , dev@dpdk.org Cc: Somnath Kotur , stable@dpdk.org References: <20180901043254.51000-1-ajit.khaparde@broadcom.com> <20180901043254.51000-2-ajit.khaparde@broadcom.com> Openpgp: preference=signencrypt Message-ID: Date: Wed, 19 Sep 2018 10:21:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/7] net/bnxt: get rid of ff pools array and use the vnic info array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 09:21:43 -0000 On 9/19/2018 10:05 AM, Ferruh Yigit wrote: > On 9/1/2018 5:32 AM, Ajit Khaparde wrote: >> From: Somnath Kotur >> >> There was no direct association between the rxq's vnic and the vnic_info[]. >> Explicitly associate the two in bnxt_mq_rx_configure(). >> >> Fixes: f7c3d72afff7 ("net/bnxt: fix Rx ring count limitation") Wrong 'Fixes' reference: Fixes: f7c3d72afff7 ("net/bnxt: fix Rx ring count limitation") Correct one seems: Fixes: 0a256e4a548b ("net/bnxt: fix Rx ring count limitation") >> Cc: stable@dpdk.org >> >> Signed-off-by: Somnath Kotur >> Signed-off-by: Ajit Khaparde > > <...> > >> void bnxt_free_vnic_attributes(struct bnxt *bp) >> { >> struct bnxt_vnic_info *vnic; >> + unsigned int i; >> >> - STAILQ_FOREACH(vnic, &bp->free_vnic_list, next) { >> + for (i = 0; i < bp->nr_vnics; i++) { >> if (vnic->rss_table) { > > Here vnic accessed without initial value [1], I guess intention was: > "vnic = &bp->vnic_info[i];" before access. > > [1] > .../drivers/net/bnxt/bnxt_vnic.c:93:7: error: variable 'vnic' is uninitialized > when used here [-Werror,-Wuninitialized] > if (vnic->rss_table) { > ^~~~ >