From: Akhil Goyal <akhil.goyal@nxp.com>
To: Akash Saxena <akash.saxena@caviumnetworks.com>,
"pablo.de.lara.guarch@intel.com" <pablo.de.lara.guarch@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"shally.verma@caviumnetworks.com"
<shally.verma@caviumnetworks.com>,
"ayuj.verma@caviumnetworks.com" <ayuj.verma@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa verify operation
Date: Tue, 16 Oct 2018 13:21:20 +0000 [thread overview]
Message-ID: <f0a4721b-d1b0-fa57-f586-61ce575c5eb9@nxp.com> (raw)
In-Reply-To: <1539265391-9606-3-git-send-email-akash.saxena@caviumnetworks.com>
On 10/11/2018 7:13 PM, Akash Saxena wrote:
> Change unit test app to check only for op->status =
> RTE_CRYPTO_OP_STATUS_SUCCESS/ERROR instead of calling rsa_verify().
>
> Signed-off-by: Ayuj Verma <ayuj.verma@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> ---
> test/test/test_cryptodev_asym.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/test/test/test_cryptodev_asym.c b/test/test/test_cryptodev_asym.c
> index 2fdfc1d..a899f99 100644
> --- a/test/test/test_cryptodev_asym.c
> +++ b/test/test/test_cryptodev_asym.c
> @@ -153,10 +153,13 @@ test_rsa_sign_verify(void)
> goto error_exit;
> }
> status = TEST_SUCCESS;
> - int ret = 0;
> - ret = rsa_verify(&rsaplaintext, result_op);
> - if (ret)
> + if (result_op->status != RTE_CRYPTO_OP_STATUS_SUCCESS) {
> + RTE_LOG(ERR, USER1,
> + "line %u FAILED: %s",
> + __LINE__, "Failed to process asym crypto op");
> status = TEST_FAILED;
> + goto error_exit;
> + }
>
> error_exit:
>
What about test_rsa_enc_dec? Do you need to remove verify from that as well?
next prev parent reply other threads:[~2018-10-16 13:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 13:43 [dpdk-dev] [PATCH v1 0/2] Changes for RSA verify operation in OpenSSL PMD and unit tests Akash Saxena
2018-10-11 13:43 ` [dpdk-dev] [PATCH v1 1/2] crypto/openssl: changes for RSA verify operation Akash Saxena
2018-10-16 13:15 ` Akhil Goyal
2018-10-16 13:17 ` Akhil Goyal
2018-10-11 13:43 ` [dpdk-dev] [PATCH v1 2/2] test/crypto: remove data verification at rsa " Akash Saxena
2018-10-16 13:21 ` Akhil Goyal [this message]
2018-10-22 12:29 ` Verma, Shally
2018-10-24 13:09 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0a4721b-d1b0-fa57-f586-61ce575c5eb9@nxp.com \
--to=akhil.goyal@nxp.com \
--cc=akash.saxena@caviumnetworks.com \
--cc=ayuj.verma@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=shally.verma@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).