From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8F40D2C4B for ; Mon, 13 Feb 2017 11:14:35 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP; 13 Feb 2017 02:14:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="224615951" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.137]) ([10.237.220.137]) by fmsmga004.fm.intel.com with ESMTP; 13 Feb 2017 02:14:33 -0800 To: "Yang, Qiming" , "dev@dpdk.org" References: <1486689994-37746-1-git-send-email-qiming.yang@intel.com> <0425f979-8198-4cc8-f70b-f1c9a037fd7f@intel.com> Cc: "Wu, Jingjing" From: Ferruh Yigit Message-ID: Date: Mon, 13 Feb 2017 10:14:33 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] FW: [PATCH] net/i40e: fix vlan insert code redundance X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 10:14:36 -0000 On 2/13/2017 10:09 AM, Yang, Qiming wrote: > Hi, Ferruh > >> -----Original Message----- >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yang, Qiming >> Sent: Friday, February 10, 2017 7:21 PM >> To: Yigit, Ferruh ; dev@dpdk.org >> Cc: Wu, Jingjing >> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix vlan insert code redundance >> >>> On 2/10/2017 1:26 AM, Qiming Yang wrote: >>>> This patch removed useless tx_flags in vlan insertion. >>> >>> Overall this looks good, I wonder what was the initial intention of >>> this code, understanding it helps to figure out if there is a hidden defect. >> >> Thank you for your remind. I'll investigate it. > > I have aligned with Helin (he contribute these code), and make sure these code is useless, these code is left by history. > >> >>> >>> This code not fixes a defect, but improves the code, is there any >>> performance gain with this? >> >> I'll do more test and give you a feedback. > > According to my test, this code will not bring any obvious performance gain, and no lose also. > And as you said this is not a bug fix, should I remove the fix line and modify the commit log? Please do if you will send a new version already, no need to send a new version just for title update. Thanks, ferruh > >> >>> If not, I am for deferring this to next release. >>> >>>> >>>> Fixes: 4861cde46116 ("i40e: new poll mode driver") >>>> >>>> Signed-off-by: Qiming Yang >>>> --- >