From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD286A09E4; Thu, 28 Jan 2021 17:59:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A517540682; Thu, 28 Jan 2021 17:59:32 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 40D924067A for ; Thu, 28 Jan 2021 17:59:30 +0100 (CET) IronPort-SDR: oz6j+0KGdJ7PzylJm/0kZNzSZ2MW5b+r4QPyNVtsQlCqVvR5ADr6n+vvMrHto531k12NLqgXwn ktalnQpMuQ5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="244355779" X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="244355779" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 08:59:30 -0800 IronPort-SDR: CoDgyuVfNyGD9hcQYryHIlJrmSzzjMWc/o1R6jd9CWilMHtLpzWNn8u2oQaZJt696PmRgIleVX SBQukwim5EtA== X-IronPort-AV: E=Sophos;i="5.79,383,1602572400"; d="scan'208";a="388897714" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.127]) ([10.213.197.127]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 08:59:28 -0800 To: Nalla Pradeep , Radha Mohan Chintakuntla , Veerasenareddy Burru Cc: jerinj@marvell.com, sburla@marvell.com, dev@dpdk.org References: <20210118093602.5449-1-pnalla@marvell.com> <20210128152220.214485-12-pnalla@marvell.com> From: Ferruh Yigit Message-ID: Date: Thu, 28 Jan 2021 16:59:26 +0000 MIME-Version: 1.0 In-Reply-To: <20210128152220.214485-12-pnalla@marvell.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 11/11] net/octeontx_ep: transmit data path function added X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/28/2021 3:22 PM, Nalla Pradeep wrote: > 1. Packet transmit function for both otx and otx2 are added. > 2. Flushing transmit(command) queue when pending commands are more than > maximum allowed value (currently 16). > 3. Scatter gather support if the packet spans multiple buffers. > > Signed-off-by: Nalla Pradeep <...> > + /* ih vars */ > + iqcmd2.ih.s.tlen = pkt_len + iqcmd2.ih.s.fsz; > + iqcmd2.ih.s.gather = gather; > + iqcmd2.ih.s.gsz = gsz; > + /* irh vars */ > + /* irh.rlenssz = ; */ > + iqcmd2.dptr = dptr; > + /* Swap FSZ(front data) here, to avoid swapping on > + * OCTEON TX side rptr is not used so not swapping. > + */ > + /* otx_ep_swap_8B_data(&iqcmd2.rptr, 1); */ More commented out code seems remaining, can you please clean all?