From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEADFA0C4E; Thu, 22 Jul 2021 12:38:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 81F554014D; Thu, 22 Jul 2021 12:38:32 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 013E840040 for ; Thu, 22 Jul 2021 12:38:32 +0200 (CEST) Received: from [192.168.100.116] (unknown [37.139.99.76]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id B23D57F53F; Thu, 22 Jul 2021 13:38:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru B23D57F53F DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1626950311; bh=L6WfsNh9Mz17pHLyp/6hPbfFCZc8XyJoCorRa7HGIbU=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=IrBDO7Vy0bh/OukUpjuZUsqhGzW9C5X+4pUoQl5fWGqWyDsp7WlZxJevi3DuDB04Y 8jxnvVU0fBxFE4hkCAP84mtA2+A2JZtmdCQ2s8scXptddAJw03gRumhRg6z+0WfliC TSJT8GrsSQ4EW9iVixxNPQvB29TMAkAXwfRjFZwg= To: Ferruh Yigit , Ajit Khaparde Cc: Jerin Jacob , Xiaoyun Li , Chas Williams , "Min Hu (Connor)" , Hemant Agrawal , Sachin Saxena , Qi Zhang , Xiao Wang , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Harman Kalra , Maciej Czekaj , Ray Kinsella , Neil Horman , Bernard Iremonger , Bruce Richardson , Konstantin Ananyev , John McNamara , Igor Russkikh , Pavel Belous , Steven Webster , Matt Peters , Somalapuram Amaranath , Rasesh Mody , Shahed Shaikh , Somnath Kotur , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Rahul Lakkireddy , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Yisen Zhuang , Lijun Ou , Beilei Xing , Jingjing Wu , Qiming Yang , Andrew Boyer , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Zyta Szpak , Liron Himi , Heinrich Kuhn , Devendra Singh Rawat , Keith Wiles , Jiawen Wu , Jian Wang , Maxime Coquelin , Chenbo Xia , Nicolas Chautru , David Hunt , Harry van Haaren , Cristian Dumitrescu , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Declan Doherty , Pavan Nikhilesh , Kirill Rybalchenko , Jasvinder Singh , Thomas Monjalon , dpdk-dev References: <20210709172923.3369846-1-ferruh.yigit@intel.com> <6655b8c1-82d8-27af-087c-c63153e79d3d@oktetlabs.ru> <61fbde10-1e3e-45a4-9877-f57f0aac2360@intel.com> <749d44ad-d7c5-307b-17a0-5b5dd9780674@intel.com> From: Andrew Rybchenko Message-ID: Date: Thu, 22 Jul 2021 13:38:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <749d44ad-d7c5-307b-17a0-5b5dd9780674@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/22/21 1:27 PM, Ferruh Yigit wrote: > On 7/22/2021 2:31 AM, Ajit Khaparde wrote: >> >> >> >> > [snip] >> > >> >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> >> index faf3bd901d75..9f288f98329c 100644 >> >> --- a/lib/ethdev/rte_ethdev.h >> >> +++ b/lib/ethdev/rte_ethdev.h >> >> @@ -410,7 +410,7 @@ enum rte_eth_tx_mq_mode { >> >>  struct rte_eth_rxmode { >> >>      /** The multi-queue packet distribution mode to be used, e.g. RSS. */ >> >>      enum rte_eth_rx_mq_mode mq_mode; >> >> -    uint32_t max_rx_pkt_len;  /**< Only used if JUMBO_FRAME enabled. */ >> >> +    uint32_t mtu;  /**< Requested MTU. */ >> > >> > Maximum Transmit Unit looks a bit confusing in Rx mode >> > structure. >> > >> >> True, but I think it is already used for Rx already as concept, I believe the >> intention will be clear enough. Do you think will be more clear if we pick a >> DPDK specific variable name? >> >> Maybe use MRU - Max Receive Unit. >> > > It can be an option, but this patch unifies 'max_rx_pkt_len' & 'mtu' => mtu, > if we switch to 'mru', we should switch all usage to 'mru', including > 'rte_eth_dev_set_mtu()' API name change, to not cause a new confusion between > 'mru' & 'mtu' difference. > > Does 'mtu' really cause this much confusion to do all this change? Reconsidering it I see no better options. Yes, mtu is a bit confusing in Rx configuration, but just a bit. >> >> >>      /** Maximum allowed size of LRO aggregated packet. */ >> >>      uint32_t max_lro_pkt_size; >> >>      uint16_t split_hdr_size;  /**< hdr buf size (header_split enabled).*/ >> > >> > [snip] >> > >>