From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 009257D4E for ; Mon, 18 Sep 2017 12:56:06 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2017 03:56:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,412,1500966000"; d="scan'208";a="1220251165" Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.79]) ([10.237.221.79]) by fmsmga002.fm.intel.com with ESMTP; 18 Sep 2017 03:56:04 -0700 To: Pablo de Lara , declan.doherty@intel.com Cc: dev@dpdk.org References: <20170818061753.55840-1-pablo.de.lara.guarch@intel.com> <20170915020937.75688-1-pablo.de.lara.guarch@intel.com> <20170915020937.75688-2-pablo.de.lara.guarch@intel.com> From: Radu Nicolau Message-ID: Date: Mon, 18 Sep 2017 11:56:04 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <20170915020937.75688-2-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_mb: add DES support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Sep 2017 10:56:07 -0000 On 9/15/2017 3:09 AM, Pablo de Lara wrote: > The Multi-buffer library now supports DES-CBC > and DES-DOCSISBPI algorithms, so this commit > extends adds support for them in the PMD. > > Signed-off-by: Pablo de Lara > Acked-by: Fan Zhang > --- > doc/guides/cryptodevs/aesni_mb.rst | 2 + > doc/guides/cryptodevs/features/aesni_mb.ini | 3 ++ > doc/guides/rel_notes/release_17_11.rst | 7 +++ > drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 74 ++++++++++++++++++-------- > drivers/crypto/aesni_mb/rte_aesni_mb_pmd_ops.c | 42 +++++++++++++++ > test/test/test_cryptodev.c | 42 +++++++++++++++ > test/test/test_cryptodev_des_test_vectors.h | 24 ++++++--- > 7 files changed, 163 insertions(+), 31 deletions(-) > > > > +#include > + > #include > #include > #include > @@ -188,6 +190,7 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops, > struct aesni_mb_session *sess, > const struct rte_crypto_sym_xform *xform) > { > + uint8_t is_aes; Nitpicking: Maybe initialize with zero and remove is_aes = 0; from the switch body? > aes_keyexp_t aes_keyexp_fn; > > if (xform == NULL) { > @@ -217,45 +220,70 @@ aesni_mb_set_session_cipher_parameters(const struct aesni_mb_op_fns *mb_ops, > switch (xform->cipher.algo) { > case RTE_CRYPTO_CIPHER_AES_CBC: > sess->cipher.mode = CBC; > + is_aes = 1; > break; > case RTE_CRYPTO_CIPHER_AES_CTR: > sess->cipher.mode = CNTR; > + is_aes = 1; > break; > case RTE_CRYPTO_CIPHER_AES_DOCSISBPI: > sess->cipher.mode = DOCSIS_SEC_BPI; > + is_aes = 1; > break; > - default: > - MB_LOG_ERR("Unsupported cipher mode parameter"); > - return -ENOTSUP; > - } > - > - /* Check key length and choose key expansion function */ > - switch (xform->cipher.key.length) { > - case AES_128_BYTES: > - sess->cipher.key_length_in_bytes = AES_128_BYTES; > - aes_keyexp_fn = mb_ops->aux.keyexp.aes128; > + case RTE_CRYPTO_CIPHER_DES_CBC: > + sess->cipher.mode = DES; > + is_aes = 0; > break; > - case AES_192_BYTES: > - sess->cipher.key_length_in_bytes = AES_192_BYTES; > - aes_keyexp_fn = mb_ops->aux.keyexp.aes192; > - break; > - case AES_256_BYTES: > - sess->cipher.key_length_in_bytes = AES_256_BYTES; > - aes_keyexp_fn = mb_ops->aux.keyexp.aes256; > + case RTE_CRYPTO_CIPHER_DES_DOCSISBPI: > + sess->cipher.mode = DOCSIS_DES; > + is_aes = 0; > break; > default: > - MB_LOG_ERR("Invalid cipher key length"); > - return -EINVAL; > + MB_LOG_ERR("Unsupported cipher mode parameter"); > + return -ENOTSUP; > } > Reviewed-by: Radu Nicolau