From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Mody, Rasesh" <Rasesh.Mody@cavium.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Shaikh, Shahed" <Shahed.Shaikh@cavium.com>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/qede: fix Tx tunnel offload notsup mask
Date: Tue, 13 Nov 2018 12:01:37 +0000 [thread overview]
Message-ID: <f11bad9b-b071-e5eb-fb9a-75a0bd6bd781@intel.com> (raw)
In-Reply-To: <1542046761-2895-1-git-send-email-rasesh.mody@cavium.com>
On 11/12/2018 6:19 PM, Mody, Rasesh wrote:
> From: Shahed Shaikh <shahed.shaikh@cavium.com>
>
> Tunneling offloads are represented by multi-bit values. So, feature
> wise tunneling offload can only be entirely supported/unsupported
> using PKT_TX_TUNNEL_MASK. Its upon PMDs to further isolate which of
> the tunneling offload types are supported by respective PMD.
> Using subset of bits from PKT_TX_TUNNEL_MASK to indicate supported vs
> unsupported offloads can lead to undesired result.
>
> Use PKT_TX_TUNNEL_MASK in QEDE_TX_OFFLOAD_MASK and use independent
> value of supported PKT_TX_TUNNEL_* in .tx_pkt_prepare() to mark
> supported tunnel offloads.
>
> Fixes: 44346c24b790 ("net/qede: fix VXLAN tunnel Tx offload flag setting")
> Cc: stable@dpdk.org
>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
> Reviewed-by: Rasesh Mody <rasesh.mody@cavium.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-11-13 12:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-12 18:19 Mody, Rasesh
2018-11-13 12:01 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f11bad9b-b071-e5eb-fb9a-75a0bd6bd781@intel.com \
--to=ferruh.yigit@intel.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=Rasesh.Mody@cavium.com \
--cc=Shahed.Shaikh@cavium.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).