From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id AEBEC20BD for <dev@dpdk.org>; Fri, 21 Sep 2018 15:47:18 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Sep 2018 06:47:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,285,1534834800"; d="scan'208";a="71835416" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga007.fm.intel.com with ESMTP; 21 Sep 2018 06:47:13 -0700 To: Thomas Monjalon <thomas@monjalon.net>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com>, Rasesh Mody <rasesh.mody@cavium.com>, Harish Patil <harish.patil@cavium.com>, Shahed Shaikh <shahed.shaikh@cavium.com>, Yong Wang <yongwang@vmware.com> Cc: dev@dpdk.org References: <20180920001853.23454-1-thomas@monjalon.net> From: Ferruh Yigit <ferruh.yigit@intel.com> Openpgp: preference=signencrypt Message-ID: <f147d295-2364-071b-49af-64cf37d0891b@intel.com> Date: Fri, 21 Sep 2018 14:47:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180920001853.23454-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] drivers/net: do not redefine bool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 21 Sep 2018 13:47:19 -0000 On 9/20/2018 1:18 AM, Thomas Monjalon wrote: > When trying to include stdbool.h in DPDK base headers, there are a lot > of conflicts with drivers which redefine bool/true/false > in their compatibility layer. > > It is fixed by including stdbool.h in these drivers. > Some errors with usage of bool type are also fixed in some drivers. > > Note: the driver qede has a surprising mix of bool and int: > (~p_iov->b_pre_fp_hsi & ETH_HSI_VER_MINOR) > where the first variable is boolean and the version is a number. > It is replaced by > !p_iov->b_pre_fp_hsi > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- > drivers/net/cxgbe/cxgbe_compat.h | 2 +- > drivers/net/e1000/base/e1000_osdep.h | 5 +---- > drivers/net/fm10k/base/fm10k_osdep.h | 8 +------- > drivers/net/fm10k/fm10k_ethdev.c | 4 ++-- > drivers/net/ixgbe/base/ixgbe_osdep.h | 6 +----- > drivers/net/ixgbe/ixgbe_ethdev.c | 16 +++++++++------- > drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- > drivers/net/qede/base/bcm_osal.h | 6 ++---- > drivers/net/qede/base/ecore_vf.c | 3 +-- > drivers/net/qede/qede_ethdev.c | 2 +- > drivers/net/vmxnet3/base/vmxnet3_osdep.h | 3 ++- > 11 files changed, 22 insertions(+), 35 deletions(-) <...> > @@ -35,6 +35,7 @@ > #ifndef _E1000_OSDEP_H_ > #define _E1000_OSDEP_H_ > > +#include <stdbool.h> > #include <stdint.h> > #include <stdio.h> > #include <stdarg.h> > @@ -87,7 +88,6 @@ typedef int64_t s64; > typedef int32_t s32; > typedef int16_t s16; > typedef int8_t s8; > -typedef int bool; > > #define __le16 u16 > #define __le32 u32 > @@ -192,7 +192,4 @@ static inline uint16_t e1000_read_addr16(volatile void *addr) > #define ETH_ADDR_LEN 6 > #endif > > -#define false FALSE > -#define true TRUE > - It is too much hassle to update Intel base driver code. What would happen if not include stdbool and keep define for base code updates? Will it break build for applications?