From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81A38A054F; Mon, 15 Mar 2021 17:59:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 650AD242741; Mon, 15 Mar 2021 17:59:08 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 485FC242739 for ; Mon, 15 Mar 2021 17:59:06 +0100 (CET) IronPort-SDR: LAtATeEfXly2nhb0NIXZYYhYiWGhyzgQQ9B5v4PcoH4vfYeV1Il5YD+nsq/zZ6hnDc3MVSUxTk 8V36S4G7e/5Q== X-IronPort-AV: E=McAfee;i="6000,8403,9924"; a="169036699" X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="169036699" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 09:59:01 -0700 IronPort-SDR: jtllSIGmLm+CZ3ezjGdJ+50V24bL6/fG3Mgt2kpj9tt8G4DgPiuKu+dKP4UNiOjTB6zVbjG4sI EXHIq0LIBk1w== X-IronPort-AV: E=Sophos;i="5.81,251,1610438400"; d="scan'208";a="449425761" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.23.61]) ([10.252.23.61]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2021 09:58:59 -0700 To: Igor Ryzhov , Elad Nachman Cc: dev , Dan Gora , Stephen Hemminger References: <20201126144613.4986-1-eladv6@gmail.com> <20210225143239.14220-1-eladv6@gmail.com> <20210225143239.14220-2-eladv6@gmail.com> <20210226074817.7e9e0a71@hermes.local> <20210301083820.640dde15@hermes.local> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Mon, 15 Mar 2021 16:58:55 +0000 MIME-Version: 1.0 In-Reply-To: <20210301083820.640dde15@hermes.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] kni: fix rtnl deadlocks and race conditions v4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/1/2021 4:38 PM, Stephen Hemminger wrote: > On Mon, 1 Mar 2021 11:10:01 +0300 > Igor Ryzhov wrote: > >> Stephen, >> >> No, I don't have a better proposal, but I think it is not correct to change >> the behavior of KNI (making link down without a real response). >> Even though we know that communicating with userspace under rtnl_lock is a >> bad idea, it works as it is for many years already. >> >> Elad, >> >> I agree with you that KNI should be removed from the main tree if it is not >> possible to fix this __dev_close_many issue. >> There were discussions about this multiple times already, but no one is >> working on this AFAIK. >> Last time the discussion was a month ago: >> https://www.mail-archive.com/dev@dpdk.org/msg196033.html >> >> Igor > > The better proposal would be to make DPDK virtio smarter. > There already is virtio devices that must handle this (VDPA) etc. > And when you can control link through virtio, then put a big warning > in KNI that says "Don't use this" > Hi Igor, Elad, I think it is reasonable to do the ifdown as async to solve the problem, still we can make sync default, and async with kernel parameter, to cover both case. I will put more details on the patches.