From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9C31A04BC; Fri, 9 Oct 2020 14:10:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F4111D596; Fri, 9 Oct 2020 14:10:04 +0200 (CEST) Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id DFFA01D58F for ; Fri, 9 Oct 2020 14:10:01 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 286852CFE98710465912; Fri, 9 Oct 2020 20:09:59 +0800 (CST) Received: from [10.67.103.119] (10.67.103.119) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Fri, 9 Oct 2020 20:09:51 +0800 To: Ferruh Yigit , , , CC: , References: <1599702678-11142-1-git-send-email-oulijun@huawei.com> <1600955105-53176-1-git-send-email-oulijun@huawei.com> <4d629d1e-1b62-31e1-dc8b-7e4cc69859e1@intel.com> From: oulijun Message-ID: Date: Fri, 9 Oct 2020 20:09:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <4d629d1e-1b62-31e1-dc8b-7e4cc69859e1@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.119] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v4] RSS key use with testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2020/9/30 21:17, Ferruh Yigit 写道: > On 9/24/2020 2:45 PM, Lijun Ou wrote: >> Consider the follow usage with testpmd: >> 1. first, startup testpmd: >> testpmd> show port 0 rss-hash key >> RSS functions: >> all ipv4-frag ipv4-other ipv6-frag ipv6-other ip >> RSS key: >> 6D5A56DA255B0EC24167253D43A38FB0D0CA2BCBAE7B30B477CB2DA38030F >> 20C6A42B73BBEAC01FA >> 2. create a rss rule >> testpmd> flow create 0 ingress pattern eth / ipv4 / udp / end actions >> rss \ >> types ipv4-udp end queues end / end >> >> 3. show rss-hash key >> testpmd> show port 0 rss-hash key >> RSS functions: >> all ipv4-udp udp >> RSS key: >> 74657374706D6427732064656661756C74205253532068617368206B65792C206F >> 76657272696465 >> >> As a result, the step 3 with RSS key and the step 1 RSS key >> is not the same. The patch[1] to solve the above problems. >> > > This is interesting, can you please provide above information in the > commit log too? > Yes， I submitted detailed operation information in patch v3 as a commit, and Yang suggested that the operation information be included in the cover letter. > Also can you please provide the details on why this happens, callstack > can help? > When you start the testpmd, the pmd driver initializes the RSS configuration. Generally, the recommended RSS hash key is used as the default key in the driver. In addition, the default key is different from the default RSS flow in testpmd without specifying RSS hash key. So， if you do not specify the RSS key when creating an RSS rule, the testpmd uses the default key as the default RSS key of the RSS rule.As a result, you may mistakenly consider that the RSS key in use is the valid default key of the NIC, actually, the key and the valid default key of the NIC are two values. > Thanks, > ferruh > > >> Lijun Ou (1): >> app/testpmd: fix the default RSS key configuration >> >> app/test-pmd/cmdline_flow.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> > > . >