DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Zijie Pan <zijie.pan@6wind.com>, dev@dpdk.org, qi.z.zhang@intel.com
Cc: beilei.xing@intel.com, thomas@monjalon.net,
	Laurent Hardy <laurent.hardy@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: add a specific API to control the LLDP agent
Date: Thu, 14 Jun 2018 16:58:14 +0100	[thread overview]
Message-ID: <f166aab8-8505-51c5-3360-c18d910502d9@intel.com> (raw)
In-Reply-To: <1527125550-8425-1-git-send-email-zijie.pan@6wind.com>

On 5/24/2018 2:32 AM, Zijie Pan wrote:
> Add a new API rte_pmd_i40e_set_lldp_cmd to control LLDP agent for i40e.
> It supports the following i40e debug lldp commands:
>     - start/stop of the LLDP agent.
>     - get local/remote of the LLDP MIB (Management Information Base).
> 
> Signed-off-by: Laurent Hardy <laurent.hardy@6wind.com>
> Signed-off-by: Zijie Pan <zijie.pan@6wind.com>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Hi Zijie, Qi,

What do you think adding a testpmd command to use this API?

First it enables testing this API and second using API gives better chance to
API to survive from possible refactoring.

Thanks,
ferruh

      parent reply	other threads:[~2018-06-14 15:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18 10:14 [dpdk-dev] [PATCH] " Zijie Pan
2018-05-18 10:27 ` Thomas Monjalon
2018-05-21  3:35   ` Zijie Pan
2018-05-21  8:39     ` Thomas Monjalon
2018-05-21  8:58       ` Laurent Hardy
2018-05-21 10:10         ` Thomas Monjalon
2018-05-21 13:11 ` Zhang, Qi Z
2018-05-22  9:47   ` Laurent Hardy
2018-05-22 13:00 ` Zhang, Qi Z
2018-05-24  1:32 ` [dpdk-dev] [PATCH v2] " Zijie Pan
2018-05-29  5:54   ` Zhang, Helin
2018-06-14 15:58   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f166aab8-8505-51c5-3360-c18d910502d9@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=laurent.hardy@6wind.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    --cc=zijie.pan@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).