From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>, dev@dpdk.org
Cc: reshma.pattan@intel.com, jananeex.m.parthasarathy@intel.com,
rmody@marvell.com, shshaikh@marvell.com, beilei.xing@intel.com,
qi.z.zhang@intel.com, alejandro.lucero@netronome.com,
pablo.de.lara.guarch@intel.com, declan.doherty@intel.com,
stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] drivers: fix possible overflow with strcat
Date: Wed, 6 Mar 2019 18:14:24 +0000 [thread overview]
Message-ID: <f17c8b2c-d409-c314-527a-83a8ccb5b562@intel.com> (raw)
In-Reply-To: <1551791666-26746-1-git-send-email-tallurix.chaitanya.babu@intel.com>
<...>
> @@ -11734,13 +11735,14 @@ static const char *get_bnx2x_flags(uint32_t flags)
>
> for (i = 0; i < 5; i++)
> if (flags & (1 << i)) {
> - strcat(flag_str, flag[i]);
> + strlcat(flag_str, flag[i], sizeof(flag_str));
> flags ^= (1 << i);
> }
> if (flags) {
> static char unknown[BNX2X_INFO_STR_MAX];
> snprintf(unknown, 32, "Unknown flag mask %x", flags);
> strcat(flag_str, unknown);
> + strlcat(flag_str, unknown, sizeof(flag_str));
Intention is to replace the 'strcat' right, seems missed to remove old code.
next prev parent reply other threads:[~2019-03-06 18:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 6:04 [dpdk-dev] [PATCH] drivers: fix to replace strcat with strncat Chaitanya Babu Talluri
2019-01-14 13:29 ` Ferruh Yigit
2019-01-14 16:24 ` Stephen Hemminger
2019-01-17 16:44 ` Thomas Monjalon
2019-01-14 14:21 ` Bruce Richardson
2019-01-15 1:53 ` Thomas Monjalon
2019-01-18 15:11 ` [dpdk-dev] [PATCH v2] " Chaitanya Babu Talluri
2019-01-18 15:23 ` Chaitanya Babu Talluri
2019-01-21 10:43 ` Parthasarathy, JananeeX M
2019-02-07 11:56 ` Ferruh Yigit
2019-02-07 12:08 ` Thomas Monjalon
2019-02-07 13:27 ` Bruce Richardson
2019-02-13 11:54 ` Ferruh Yigit
2019-02-27 6:02 ` [dpdk-dev] [PATCH v3] drivers: fix to replace strcat with strlcat Chaitanya Babu Talluri
2019-02-27 9:43 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-02-27 9:49 ` [dpdk-dev] " Bruce Richardson
2019-02-27 10:26 ` Pattan, Reshma
2019-03-05 13:14 ` [dpdk-dev] [PATCH v4] drivers: fix possible overflow with strcat Chaitanya Babu Talluri
2019-03-06 18:14 ` Ferruh Yigit [this message]
2019-03-07 12:56 ` [dpdk-dev] [PATCH v5] " Chaitanya Babu Talluri
2019-03-13 18:39 ` Ferruh Yigit
2019-03-14 13:34 ` [dpdk-dev] [PATCH v6] drivers/net: " Chaitanya Babu Talluri
2019-03-14 13:34 ` Chaitanya Babu Talluri
2019-03-14 14:09 ` Pattan, Reshma
2019-03-14 14:09 ` Pattan, Reshma
2019-03-18 12:41 ` [dpdk-dev] [PATCH v7] drivers/net: fix possible overflow using strlcat Chaitanya Babu Talluri
2019-03-18 12:41 ` Chaitanya Babu Talluri
2019-03-20 20:18 ` Ferruh Yigit
2019-03-20 20:18 ` Ferruh Yigit
2019-03-22 7:51 ` [dpdk-dev] [PATCH v8] " Chaitanya Babu Talluri
2019-03-22 7:51 ` Chaitanya Babu Talluri
2019-03-22 8:02 ` [dpdk-dev] [EXT] " Shahed Shaikh
2019-03-22 8:02 ` Shahed Shaikh
2019-03-22 10:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2019-03-22 10:35 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f17c8b2c-d409-c314-527a-83a8ccb5b562@intel.com \
--to=ferruh.yigit@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=jananeex.m.parthasarathy@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=reshma.pattan@intel.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=tallurix.chaitanya.babu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).