From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40863A09E9; Wed, 9 Dec 2020 01:14:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98D8BC8F8; Wed, 9 Dec 2020 01:14:23 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 8D8B372D9 for <dev@dpdk.org>; Wed, 9 Dec 2020 01:14:21 +0100 (CET) IronPort-SDR: rpa4EIT4kv/S/OtJ0JMOUadpKms3SEzWZoZRktlKAiMeYVZ+Z5S9SlvPT9zSLRPCLcToMUQF99 2x6QXFIVAU/Q== X-IronPort-AV: E=McAfee;i="6000,8403,9829"; a="171420277" X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208,217";a="171420277" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 16:14:17 -0800 IronPort-SDR: JEkudNWPCD1+65CQUc+wAQuNUJ4Es8udXHsj8OHBEhSn5OcIc21e3iEZ6aJIVEJ1iapwuM6Wmk stb45SVEvvrg== X-IronPort-AV: E=Sophos;i="5.78,404,1599548400"; d="scan'208,217";a="370589566" Received: from pkadam-mobl1.amr.corp.intel.com (HELO [10.209.7.12]) ([10.209.7.12]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2020 16:14:16 -0800 To: Bruce Richardson <bruce.richardson@intel.com>, Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, talshn@nvidia.com, ferruh.yigit@intel.com, beilei.xing@intel.com, jia.guo@intel.com References: <20201205011020.6276-1-pallavi.kadam@intel.com> <20201205011020.6276-3-pallavi.kadam@intel.com> <1656459.hZBu3j2uRN@thomas> <20201207091408.GA19@bricha3-MOBL.ger.corp.intel.com> From: "Kadam, Pallavi" <pallavi.kadam@intel.com> Message-ID: <f18aeb77-28cb-9c21-b2e7-b851f88388af@intel.com> Date: Tue, 8 Dec 2020 16:14:15 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201207091408.GA19@bricha3-MOBL.ger.corp.intel.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/3] net/i40e: add changes to support i40e PMD on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 12/7/2020 1:14 AM, Bruce Richardson wrote: > On Sun, Dec 06, 2020 at 04:49:40PM +0100, Thomas Monjalon wrote: >> 05/12/2020 02:10, Pallavi Kadam: >>> --- a/drivers/net/meson.build >>> +++ b/drivers/net/meson.build >>> @@ -1,9 +1,6 @@ >>> # SPDX-License-Identifier: BSD-3-Clause >>> # Copyright(c) 2017 Intel Corporation >>> >>> -if is_windows >>> - subdir_done() >>> -endif >>> >>> drivers = ['af_packet', >>> 'af_xdp', >>> @@ -56,6 +53,12 @@ drivers = ['af_packet', >>> 'virtio', >>> 'vmxnet3', >>> ] >>> + >>> +if is_windows >>> + drivers = ['i40e', >>> + ] >>> +endif >> Let's not add an alternative list please. >> I prefer disabling compilation in other drivers. >> > +1 for this. It's more work, but it keeps the existing style where all info > about whether a driver should be built, and how it's built in a single file > for each driver. Thanks Thomas and Bruce. Will incorporate this change in v2.