From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60354A00BE; Thu, 17 Feb 2022 13:47:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4B4AB41153; Thu, 17 Feb 2022 13:47:57 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D880441150 for ; Thu, 17 Feb 2022 13:47:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645102075; x=1676638075; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=3rcCFkWYVCeHYWu3ILaY/i3fm6dzxf2NbkRS/15kuSw=; b=kwwHo2GXCSzpFFEI9jDxPIHN3R3ms9Gp4SnE7Dib2aAp3qSLqPIm5cYu gy14ThbFDT4NLx6PDb1xFc2A7kjKE9Mi0yYaPSkLPKDBb5D7M6lHbzZf0 KnLS1e/EFL7Qs6lvVXqKheaSWjRyb0TPsVTmUoHv4mJ9iAbY9JJRqwm33 MR5wqQ24fYBM0wrYRe9hsIPIXeUK6plHNEIHw15ftl60qPscXocx6rnFY gi2tiAPls+A08ZXCl2V/amhLsHMmY2Q1eFnJyubAFnh+xyTnl0obL3SbZ 11/pLKM0EBM8B709R9CAhAFke3qXFhLLUD+rTghZUPclMU5JngAk+k1Z5 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="250808935" X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="250808935" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2022 04:47:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,375,1635231600"; d="scan'208";a="704782716" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga005.jf.intel.com with ESMTP; 17 Feb 2022 04:47:53 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 04:47:53 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 17 Feb 2022 04:47:52 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 17 Feb 2022 04:47:52 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 17 Feb 2022 04:47:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lBvhN9S2EtCzGwn31qIovmpN5yS2iIecVrbIr61MrLnT1aBBiZa7OAF5pWHo8Ud01E3DCaUOmwuFuZtcbg/QnPDx5ZG1fMQm0cmTULfdwrH1HJd7Y4DulQoFCEs4FBBGPhdyyyImRzUpqTFlstnSRdu07s7wkU5sMHJMUkwVMcIESSQHNkwJxxUN2KPPWw0aIBG4MRPDrS/We3eSYCkFLdj560uTg2J8qGv+6mTUQqZnm/YyocKetKMcSZbes5CX5MAcSt52Q7dN7IDnhJTfnnauZXNiqPW9i3kYKe+3lBSIr0I36GBKsshtcWiDYxyWsCh1ckfEVdlPVwoGh/hcfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sXR9i9StlV5jQ4wkfiIcLLjCAo/Ah+5ZkRqSfVokH38=; b=UbcVIYzwkmf6VR6j3ZRSVX3YMobmQcVcvrJq4oJJArrhbIN5nW8NfNtNv/QMIAq9eZ9nmT71i9We+vVOgu/iezyppAJ1pCvIfxnNs9rU/zgwDtnp+vKQW+xzuXo+Ziyci/s047wIsTM/RuuhV+r7WQ/DTZwHWd70JERGNH4PpMZnDtpkV5WbD6hquAyMkHGdawKsgdCvM0XL+zofbixSrLjQMH7DmdfqD3p0s4ovUtpwnidioF/l2so2FQzGue/fddXsCkdYOuHE0lhEAkF2wxUmcth7fIWSS4Y6mdlHxFx3xwRkiZ7qpjEGpB3SkrsHSR9sKrpMw7RIGyzzb25tHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4885.namprd11.prod.outlook.com (2603:10b6:510:35::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.17; Thu, 17 Feb 2022 12:47:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4995.017; Thu, 17 Feb 2022 12:47:44 +0000 Message-ID: Date: Thu, 17 Feb 2022 12:47:39 +0000 Content-Language: en-US To: David Marchand , Ciara Loftus CC: dev , Stephen Hemminger , "Burakov, Anatoly" References: <20220208134800.52142-1-ciara.loftus@intel.com> <20220209094808.41464-1-ciara.loftus@intel.com> From: Ferruh Yigit Subject: Re: [PATCH v4] net/af_xdp: re-enable secondary process support X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0095.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::35) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db03fe3b-d433-4500-be91-08d9f213b140 X-MS-TrafficTypeDiagnostic: PH0PR11MB4885:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:605; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FQbQLfR7zuv/Yggchr4EMLEk0H1H+FIGRlXBShG0bzguGg4J/g92ZMVfQ3iNiouLfL9SF/W3mbnHdBKXuCQiV8RvD65plz1WbZhmezjrEy52BJBPICV7nFw2MnEPSIYrH8P5HEZFDGydmSPjh+ZMNQdcLMFR5xfMPB8FzvjHzprDFqiqvChMufSPFZtQhbJnvZ5RP/6bT+bJFIBGYdu9JEo2YLQRaQHWS5UAHd0f4E6WPvWeZOdzUW/a7iT+FE79db7IzflvkIu/CqbIrfEU9ClzymsQW8sFD1YfMLEFaZ+l7spiHfQHGzzOyBEgk01izzOcQq5y24AR7XmSg5VoiAQg2NW0m/4WIUvIWeEP7h0ZJwl75yUUvSVR52N4cIdxC5ZOpSKHd+pgM8q7NfPaTBnYrD6lyLrNO4rhpUfyu20N8kIQ5xoWjaAYUNzBvBMZocecgIkoaCcP7Z2drdi1Sre3dQOqATee2II0C/9fSduoGwsuluL3qL2ZAXKhoDfEAIkyQ26EcMoPzZT/SWTIQbdYfaSvSQM+vPjbsx/hqi0q8QW2hIAaAuYqcsTEWQyC0OASaTBaEpeH1J/CjT44CPzztOYSOlXHSGejE6kLA/Tm4L76EFw/dJBctceI6FNJpj2tseaXpEQrorKZsuCnxKhzKV8IBlRCHOB78tBCvhwo0fur9uYaZ8qRet6qFt7iJZsoGxZV2a6Geal3hs9MNpU+IpWrVfDQopbhXisBQL3uyfUf07unyGO2NgVh9+o9Y/3qo+GYPSoipR0x0KhtKit9KXP/sfcV10tvEG5+x0M= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31696002)(107886003)(2906002)(6666004)(6512007)(8936002)(6506007)(8676002)(53546011)(4744005)(44832011)(5660300002)(110136005)(54906003)(508600001)(2616005)(36756003)(66476007)(6486002)(38100700002)(66556008)(82960400001)(86362001)(966005)(4326008)(66946007)(316002)(31686004)(6636002)(186003)(26005)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VE1jWGhXRXp6VGYwZEZteEE2U3poUTk3eUt3L2FMLzNGK1BWaTk4bTNKWG0v?= =?utf-8?B?VTNVYzA3SjVGNjd6RVNkbzdGSWphNkRsYUZjbVZvRXlaeUhvOHNrWUpxeG5l?= =?utf-8?B?WktRK2daMlZsd3ByMnRWYkN3ZHBOZkp5YVd0ZkVrZVhzcndXMjlRWGc2aWNt?= =?utf-8?B?QXhycEptbzBISXlKdVB3bkNqMzg1dmFNZk4wYzA5bXhkanVDNUV6eWFGcFVH?= =?utf-8?B?VGEyZXhDdlIrajNud09tMnVZY0ZiaXZ1STNOV1Y4VmdUZG1taG5Yb3N2UVJX?= =?utf-8?B?b0tRMU82aHZZY0U0WmVYQ3V4c1BPdTFGRStlTG4wWTJOMW15ck9WVzFrMEZ0?= =?utf-8?B?Mjl1Z09VRXZkbEtaUEV1YXRIc1NUYzdDQzRhbHI0QUlGdWd0UTdXemlndk1l?= =?utf-8?B?dFo4REJJVDNtTHpGRnA5NUp6N1g2UE9BeldJQWhMSE5NMERLb0ROTHZaU3d6?= =?utf-8?B?bmNHQkpTL2pKcXZ4NDJ3cmxmWnlJK2NnWmlUalNxb0FqY0tySlorelkrajYy?= =?utf-8?B?SCs5QVk5MGJ1VmhneTJlaEVhT0NoL0NEczFXcXdlL3FpdGdHUTZwZk1WR21a?= =?utf-8?B?aXRmdWVTL2g1dDhTdjRNM1duNkhPZXl4QVRGdUN5NlJuYmZra3dHczA3VHVx?= =?utf-8?B?V2h4QWpWanhxTE9IQnl5R0ZicGl1TVRVRU1uelpuRnJTaG1iYmttWG9mU0xn?= =?utf-8?B?RkdVV0YrbGJhNG1LdnpDWU5IWWFpdUk1KzZnL0VoMWtJZXJHN1hWWjBnOFhP?= =?utf-8?B?UVplcjVQeDB6RzlWQkdmYkxOUmtxT082ZEI1Z1lKSGpkTTM5SU9qYVdpTjJH?= =?utf-8?B?YWd2MUM2ZHZwemRTYWJZdE1abGdwOUttZXNxc0xvdEJ3YTZlZWR3WnBZcElR?= =?utf-8?B?eG9IUXpxOVdySm1hT0pVTjNlemlqcm9GRlI2bHZrVDFDTWNWT2I5UVFxeXFM?= =?utf-8?B?Q1FrSEt4QTFnSStUR21ibGw1YkM3YkpmbXRPVlpGaGU1b0Noby9xT21RWHJI?= =?utf-8?B?Z2JSVkgySE5GVXJJTUVJOG8vUktNMWVaZStRWndxNmpYMjNnOGxqSnV1Q3lv?= =?utf-8?B?WlpOcXBkTzhBekVGb0lLM1diSDJPMjhKaEo1SkxwcUFTdzF6SDZ2N1FXeDNM?= =?utf-8?B?cUplQ0pkYldCMitVTnVXYkpjYmhuUEJnUVUrUHFMMjJCRTU5QWdDa3FydFZO?= =?utf-8?B?QWtMaDUxcGRnV0NpdnFBTTdKWEx4K1VTd1YwUm1oWG50YUhLbXJ0L1p5ZUlR?= =?utf-8?B?QTJLclBwRHE2RG1ZSVY1cFhGUVIzTVhXWTN0bmU4anFyTDhRVC9CODM2QXp3?= =?utf-8?B?R3VodkFZWGlSMGI4bTl5bGk1blU4dWswVEhBK0tFamNNTmIxZHdYSE4zWDNF?= =?utf-8?B?eHExdkp4TDRBN3RUSnE2cWNIRXVmUUJ4dDVWaEdPeHo0L0xIUTVMcVppUyts?= =?utf-8?B?YUwvU29TKys1YmdsaWFlcE8xV3JwZHBxWmc0T1l1K2kzOGVJR3BqVklNd2lt?= =?utf-8?B?WlpLS2tLQlBxNzBCY3F0M01Mcmtiemdlc0JCMG5SVEdQM2VrcXJ6S1VLaHZy?= =?utf-8?B?eGZSd0gzSWgyRjZnZXFWd2paeVd1R043UU9TL0kzTmJ2bCtOWmVmL3ZBQUN1?= =?utf-8?B?TUJuM0NCN3MzQnArdE1wS09pNVhQSjVmaU9PalZnZDdjZTdHMHZ1UFFyZDBB?= =?utf-8?B?bUtraG9qc0plRytLTDdMZWtEdWV2V3JTTytDM3BINkZlemNuNWZuTldnNllv?= =?utf-8?B?a1dFVHF1eGZlQlVBaWxlM25WTFRVcWFRSjdLTzBMc1o0amlTU2FhaDVEOTIx?= =?utf-8?B?NzVRcVR1V0tkSzdmWTFkZWtrcWxxRFR3dGpDN3V4MnZkdkVHamNhZ2ZhUXc3?= =?utf-8?B?T1hPZE5TSlFadnNOY2VZTUZ1enFNZStGMHEyRWJjL3g2NDBOZ1lLZmk1ZzhT?= =?utf-8?B?OVI5Wk90RHR6YlNWZldjall2cXVXUklPbXk0REVWUEc3VHZQNkdMNk5MOG10?= =?utf-8?B?V3U5dktURWtJcWUrMVBKQlVyMmRuUXpoaUY3cFo4UDB5cjM5UlhEamFCR01i?= =?utf-8?B?Q0pBcHp4Z1M3MmhXZDFSYS9QNnV4NW1IQTBRS1k1RXV6T0N4N0VhZjdXOHcr?= =?utf-8?B?dmxpRFdXMGtRc1ErcWlxWXBZdW5tRzVtME0xR3VHaWMzbUhiVEVuemw5UUNi?= =?utf-8?Q?a9CchUGMW1/Ah03T3AAjmSA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: db03fe3b-d433-4500-be91-08d9f213b140 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2022 12:47:44.4558 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V6vmm7xFm7AWxsLLJtchaQTxWwam8XQp5e832gOs/vvoF2Z1ltX9QWMYXtr++Q/ld+pz60hxULlDKMMmRusrdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4885 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/17/2022 12:44 PM, David Marchand wrote: > On Wed, Feb 9, 2022 at 10:48 AM Ciara Loftus wrote: >> @@ -1836,6 +2008,17 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev) >> return -1; >> } >> >> + /* Register IPC callback which shares xsk fds from primary to secondary */ >> + if (!afxdp_dev_count) { >> + ret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds); >> + if (ret < 0) { > > This breaks --in-memory mode. > It should be instead ret < 0 && rte_errno != ENOTSUP > > Can you double check? > Thanks. > There is already a patch for it [1], if it is reviewed/tested, I can merge quickly. [1] https://patches.dpdk.org/project/dpdk/patch/2c422567d3640972@cs.arizona.edu/ > >> + AF_XDP_LOG(ERR, "%s: Failed to register multi-process IPC callback: %s", >> + name, strerror(rte_errno)); >> + return -1; >> + } >> + } > >