From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0775A09D9; Wed, 11 Nov 2020 13:34:27 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B4FCF90; Wed, 11 Nov 2020 13:34:26 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id B1FC5DED for ; Wed, 11 Nov 2020 13:34:24 +0100 (CET) IronPort-SDR: B6Yvm0RBB/LJ+qgOSlBBD0ymrJN/VusoPQi1Oy3eyNPSxG+A/Mg6HzMKXqbhRtsg+o3d46bfsK +1qhpfJ0fzdg== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="149987134" X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="149987134" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 04:34:21 -0800 IronPort-SDR: kXiqtrw9CPMEdV5MEci971NfENh6ixaEe7N7daVD+DnguuRJ3W2MUtEIp5rRCs8/nVLALuYN/v ADBoP2sBxPxg== X-IronPort-AV: E=Sophos;i="5.77,469,1596524400"; d="scan'208";a="473836760" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.123]) ([10.213.241.123]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 04:34:19 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , david.marchand@redhat.com References: <20201109130035.3948462-1-ferruh.yigit@intel.com> <3526179.Ta2yc0qjKd@thomas> <2240726.PXfc15pV6C@thomas> <3084224.aG0oiDBsVl@thomas> From: Ferruh Yigit Message-ID: Date: Wed, 11 Nov 2020 12:34:15 +0000 MIME-Version: 1.0 In-Reply-To: <3084224.aG0oiDBsVl@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] devtools: fix 32-bits build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/9/2020 9:02 PM, Thomas Monjalon wrote: > 09/11/2020 18:44, Thomas Monjalon: >> 09/11/2020 18:20, Thomas Monjalon: >>> 09/11/2020 18:15, Ferruh Yigit: >>>> On 11/9/2020 5:01 PM, Thomas Monjalon wrote: >>>>> 09/11/2020 17:48, Ferruh Yigit: >>>>>> I can send a new version to reset 'CUSTOM_PKG_CONFIG_PATH', >>>>>> what is the intention/plan with the config file? >>>>> >>>>> You should use a config file to set PKG_CONFIG_PATH, PATH, >>>>> DPDK_MESON_OPTIONS, etc accordingly to build with all >>>>> your non-installed dependencies. >>>>> CUSTOM_PKG_CONFIG_PATH is a way to avoid using the config file >>>>> in a single case. >>>>> >>>> >>>> Either use 'PKG_CONFIG_PATH' environment variable or a config file, both has the >>>> same problem that we need two different pkg config path, one for 64bit and one >>>> for 32bit. >>> >>> No. In the config file, you can set the right value by testing $DPDK_TARGET. >>> Note: the config file is a shell script. >>> >>>> v2 of this patch provides a way to use correct one when needed. >>> >>> This is not a global fix. >>> >>>> Moving the default values from system environment or script hardcoded values to >>>> a config file is something else and can be done later, what do you think? >>> >>> The root cause of your issue is using variables from the environment. >>> The global fix is then to reset them all, >>> while keeping a default value for PATH which is not only for compilation config. >> >> This is what we have currently: >> >> export PATH=$default_path >> export PKG_CONFIG_PATH=$default_pkgpath >> export CPPFLAGS=$default_cppflags >> export CFLAGS=$default_cflags >> export LDFLAGS=$default_ldflags >> unset DPDK_MESON_OPTIONS >> >> The PATH needs to be restored at each run to avoid using a wrong toolchain. >> The default value is best taken from the start environment, >> at the condition no conflicting toolchain is already set. >> >> PKG_CONFIG_PATH is specific to each target. >> I believe it can be reset at each run and configured >> only from the config file. >> A default PKG_CONFIG_PATH for all targets does not make any sense. >> >> CPPFLAGS, CFLAGS and LDFLAGS could be used to customize some options >> applying to all targets in some build tests without touching the config file. >> >> DPDK_MESON_OPTIONS could be the same as CFLAGS: take a global default from env >> and restore the value at each run, so each target can have additional options >> from the config file. > > The implementation of the above is done in this patch: > https://patches.dpdk.org/patch/83861/ > > self nack this patch on behalf of above one.