DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: David Marchand <david.marchand@redhat.com>,
	wangyunjian <wangyunjian@huawei.com>,
	Luca Boccassi <bluca@debian.org>,
	Kevin Traynor <ktraynor@redhat.com>
Cc: dev <dev@dpdk.org>, Hemant Agrawal <hemant.agrawal@nxp.com>,
	Sachin Saxena <sachin.saxena@nxp.com>,
	"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
	xudingke <xudingke@huawei.com>, dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] vfio: fix check for vfio_group_fd
Date: Thu, 21 May 2020 13:53:49 +0100
Message-ID: <f1d7e035-dbb5-000e-3cb2-0b6d9148fcfe@intel.com> (raw)
In-Reply-To: <CAJFAV8wTshK8Jok8Tz_5LWs52yUmuk8fRzPsm1VMs8pH3h0ahw@mail.gmail.com>

On 19-May-20 8:43 AM, David Marchand wrote:
> On Tue, May 19, 2020 at 5:42 AM wangyunjian <wangyunjian@huawei.com> wrote:
>> From: Yunjian Wang <wangyunjian@huawei.com>
>> The issue is that a file descriptor at 0 is a valid one. Currently
>> the file not found, the return value will be set to 0. As a result,
>> it is impossible to distinguish between a correct descriptor and a
>> failed return value. Fix it to return -ENOENT instead of 0.
>> Fixes: b758423bc4fe ("vfio: fix race condition with sysfs")
>> Fixes: ff0b67d1c868 ("vfio: DMA mappinge")
>> Cc: stable@dpdk.org
> This patch reverts the (marked for stable) fix b758423bc4fe ("vfio:
> fix race condition with sysfs") and comes with a different fix.
> - Kevin, Luca, I would put this b758423bc4fe backport on hold.
> - Anatoly, I don't want to put 20.05 at risk.
> My simple question for 20.05 is, should we revert b758423bc4fe?

No, let's not revert anything.

As far as i can tell, this patch is a more complete fix, but it 
essentially does the same thing, just in a different (and better) way. 
Still, i haven't reviewed it in detail.

> - This patchset will go to 20.08 as I don't feel confident in taking it now.

Yes, let's leave it for 20.08.


  reply	other threads:[~2020-05-21 12:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  3:42 [dpdk-dev] " wangyunjian
2020-05-19  7:43 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-05-21 12:53   ` Burakov, Anatoly [this message]
2020-05-22  7:36     ` David Marchand
2020-05-27 10:45     ` Kevin Traynor
2020-07-29 11:43       ` wangyunjian
2020-09-17 11:44 ` [dpdk-dev] " Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1d7e035-dbb5-000e-3cb2-0b6d9148fcfe@intel.com \
    --to=anatoly.burakov@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerry.lilijun@huawei.com \
    --cc=ktraynor@redhat.com \
    --cc=sachin.saxena@nxp.com \
    --cc=stable@dpdk.org \
    --cc=wangyunjian@huawei.com \
    --cc=xudingke@huawei.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git