From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 100A2A0093; Thu, 21 May 2020 14:53:57 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 608B11D6B9; Thu, 21 May 2020 14:53:56 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CD8681D6B0; Thu, 21 May 2020 14:53:53 +0200 (CEST) IronPort-SDR: aa6kWCbQ37SYIsRX5LgV9qkf4+/7zHchhNKqT+EFoTSGgwfJNWIIquestg2ejPNnozIaSvflB7 syS2Ij8tnu0Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 05:53:52 -0700 IronPort-SDR: LE9TsLoGi/U3MTdoKrD6xMOaSqOT3UTIcPSZoIJliYrhfYajKVGu9YDaMh7AKVvN0jCnKgB1XH VTYcYBoLJwwA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,417,1583222400"; d="scan'208";a="283037723" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.212.74.109]) ([10.212.74.109]) by orsmga002.jf.intel.com with ESMTP; 21 May 2020 05:53:50 -0700 To: David Marchand , wangyunjian , Luca Boccassi , Kevin Traynor Cc: dev , Hemant Agrawal , Sachin Saxena , "Lilijun (Jerry)" , xudingke , dpdk stable References: <1589859720-16224-1-git-send-email-wangyunjian@huawei.com> From: "Burakov, Anatoly" Message-ID: Date: Thu, 21 May 2020 13:53:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 1/2] vfio: fix check for vfio_group_fd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 19-May-20 8:43 AM, David Marchand wrote: > On Tue, May 19, 2020 at 5:42 AM wangyunjian wrote: >> >> From: Yunjian Wang >> >> The issue is that a file descriptor at 0 is a valid one. Currently >> the file not found, the return value will be set to 0. As a result, >> it is impossible to distinguish between a correct descriptor and a >> failed return value. Fix it to return -ENOENT instead of 0. >> >> Fixes: b758423bc4fe ("vfio: fix race condition with sysfs") >> Fixes: ff0b67d1c868 ("vfio: DMA mappinge") >> Cc: stable@dpdk.org > > This patch reverts the (marked for stable) fix b758423bc4fe ("vfio: > fix race condition with sysfs") and comes with a different fix. > > - Kevin, Luca, I would put this b758423bc4fe backport on hold. > > - Anatoly, I don't want to put 20.05 at risk. > My simple question for 20.05 is, should we revert b758423bc4fe? No, let's not revert anything. As far as i can tell, this patch is a more complete fix, but it essentially does the same thing, just in a different (and better) way. Still, i haven't reviewed it in detail. > > - This patchset will go to 20.08 as I don't feel confident in taking it now. > Yes, let's leave it for 20.08. -- Thanks, Anatoly