From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DF51A0C40; Fri, 25 Jun 2021 08:59:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4686140698; Fri, 25 Jun 2021 08:59:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 8542F4068A for ; Fri, 25 Jun 2021 08:59:06 +0200 (CEST) IronPort-SDR: 1PD/eboN5VplOBuV9YAkcYQAtSW9K2POz4T2mmCNw+tWCTOCgENRmbD7jh3N/HzxWzv1yoyESg QLMspUwwLyrg== X-IronPort-AV: E=McAfee;i="6200,9189,10025"; a="207440656" X-IronPort-AV: E=Sophos;i="5.83,298,1616482800"; d="scan'208";a="207440656" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2021 23:59:05 -0700 IronPort-SDR: EvwAhg7qIDIzqKqy1e+oIzn5BDwrwKf2stv2s/a3Yx8sZWgQ8B5Dz93RhOBcGs3lxR1dl44Axx OAMBvI58RXvQ== X-IronPort-AV: E=Sophos;i="5.83,298,1616482800"; d="scan'208";a="455348466" Received: from amandee1-mobl.gar.corp.intel.com (HELO [10.213.80.112]) ([10.213.80.112]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jun 2021 23:59:03 -0700 To: Andrew Rybchenko , Ori Kam , Jan Viktorin , "dev@dpdk.org" Cc: NBU-Contact-Thomas Monjalon , Ferruh Yigit References: <20210623091825.16269-1-viktorin@cesnet.cz> From: "Singh, Aman Deep" Message-ID: Date: Fri, 25 Jun 2021 12:28:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-dev] [PATCH] ethdev: fix doc comment for struct rte_flow_action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 6/23/2021 7:43 PM, Andrew Rybchenko wrote: > On 6/23/21 4:39 PM, Ori Kam wrote: >> Hi Jan, >> >>> -----Original Message----- >>> From: Jan Viktorin >>> Sent: Wednesday, June 23, 2021 12:18 PM >>> >>> The struct rte_flow_action was missing from DPDK API documentation. >>> >>> Signed-off-by: Jan Viktorin >>> --- >>> lib/ethdev/rte_flow.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index >>> 961a5884fe..70f455d47d 100644 >>> --- a/lib/ethdev/rte_flow.h >>> +++ b/lib/ethdev/rte_flow.h >>> @@ -3278,7 +3278,7 @@ rte_flow_dynf_metadata_set(struct rte_mbuf *m, >>> uint32_t v) >>> *RTE_FLOW_DYNF_METADATA(m) = v; >>> } >>> >>> -/* >>> +/** >>> * Definition of a single action. >>> * >>> * A list of actions is terminated by a END action. >>> -- >>> 2.32.0 >> Acked-by: Ori Kam >> Thanks, >> Ori >> > Not that important, but it looks like a fix which should be > backported to stable branches as well. > Shouldn't "Fixes:" be added with Cc to stable? > > Andrew. Acked-by: Aman Deep Singh Thanks, Aman