From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Marvin Liu <yong.liu@intel.com>,
xiaolong.ye@intel.com, zhihong.wang@intel.com,
ferruh.yigit@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check
Date: Tue, 12 May 2020 15:24:58 +0200 [thread overview]
Message-ID: <f20e6074-4f8d-3387-ec4b-c7e8b23fc2bd@redhat.com> (raw)
In-Reply-To: <20200512131806.33087-1-yong.liu@intel.com>
On 5/12/20 3:18 PM, Marvin Liu wrote:
> Runtime checks for vectorized datapath are organized into device
> configuration function. Remove duplicated check in device init
> function.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 49ccef12c7..312871cb48 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1965,10 +1965,8 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
> PMD_DRV_LOG(INFO,
> "building environment do not support packed ring vectorized");
> #else
> - if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) {
> - hw->use_vec_rx = 1;
> - hw->use_vec_tx = 1;
> - }
> + hw->use_vec_rx = 1;
> + hw->use_vec_tx = 1;
> #endif
> }
> }
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2020-05-12 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 13:18 Marvin Liu
2020-05-12 13:24 ` Maxime Coquelin [this message]
2020-05-15 8:38 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f20e6074-4f8d-3387-ec4b-c7e8b23fc2bd@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xiaolong.ye@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).