* [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check
@ 2020-05-12 13:18 Marvin Liu
2020-05-12 13:24 ` Maxime Coquelin
2020-05-15 8:38 ` Maxime Coquelin
0 siblings, 2 replies; 3+ messages in thread
From: Marvin Liu @ 2020-05-12 13:18 UTC (permalink / raw)
To: maxime.coquelin, xiaolong.ye, zhihong.wang, ferruh.yigit; +Cc: dev, Marvin Liu
Runtime checks for vectorized datapath are organized into device
configuration function. Remove duplicated check in device init
function.
Signed-off-by: Marvin Liu <yong.liu@intel.com>
diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index 49ccef12c7..312871cb48 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1965,10 +1965,8 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
PMD_DRV_LOG(INFO,
"building environment do not support packed ring vectorized");
#else
- if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) {
- hw->use_vec_rx = 1;
- hw->use_vec_tx = 1;
- }
+ hw->use_vec_rx = 1;
+ hw->use_vec_tx = 1;
#endif
}
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check
2020-05-12 13:18 [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check Marvin Liu
@ 2020-05-12 13:24 ` Maxime Coquelin
2020-05-15 8:38 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2020-05-12 13:24 UTC (permalink / raw)
To: Marvin Liu, xiaolong.ye, zhihong.wang, ferruh.yigit; +Cc: dev
On 5/12/20 3:18 PM, Marvin Liu wrote:
> Runtime checks for vectorized datapath are organized into device
> configuration function. Remove duplicated check in device init
> function.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>
> diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
> index 49ccef12c7..312871cb48 100644
> --- a/drivers/net/virtio/virtio_ethdev.c
> +++ b/drivers/net/virtio/virtio_ethdev.c
> @@ -1965,10 +1965,8 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
> PMD_DRV_LOG(INFO,
> "building environment do not support packed ring vectorized");
> #else
> - if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F)) {
> - hw->use_vec_rx = 1;
> - hw->use_vec_tx = 1;
> - }
> + hw->use_vec_rx = 1;
> + hw->use_vec_tx = 1;
> #endif
> }
> }
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check
2020-05-12 13:18 [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check Marvin Liu
2020-05-12 13:24 ` Maxime Coquelin
@ 2020-05-15 8:38 ` Maxime Coquelin
1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2020-05-15 8:38 UTC (permalink / raw)
To: Marvin Liu, xiaolong.ye, zhihong.wang, ferruh.yigit; +Cc: dev
On 5/12/20 3:18 PM, Marvin Liu wrote:
> Runtime checks for vectorized datapath are organized into device
> configuration function. Remove duplicated check in device init
> function.
>
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-15 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12 13:18 [dpdk-dev] [PATCH] net/virtio: remove duplicated runtime check Marvin Liu
2020-05-12 13:24 ` Maxime Coquelin
2020-05-15 8:38 ` Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).