From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F73CA04B1; Tue, 24 Nov 2020 10:31:53 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2EAE4C912; Tue, 24 Nov 2020 10:31:51 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 47CB8C90E for ; Tue, 24 Nov 2020 10:31:48 +0100 (CET) IronPort-SDR: +8JWhfjHXRy+i0M2++6a/bjgVKn0EI4Lgl97SBrO9M9CW7r148iXwerCzQY2KmIR+kjgnQApna JGw2doFtZnFQ== X-IronPort-AV: E=McAfee;i="6000,8403,9814"; a="151176453" X-IronPort-AV: E=Sophos;i="5.78,365,1599548400"; d="scan'208";a="151176453" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 01:31:45 -0800 IronPort-SDR: VykOeY6q/kp/NOXMBG9w/l3LfLZdZ7tI1aFETlhMBVOjV2cMDOcXUkVbWjqSkr+nno+FDEvtTU CA7oWd2IXkdQ== X-IronPort-AV: E=Sophos;i="5.78,365,1599548400"; d="scan'208";a="370314063" Received: from jkearney-mobl.ger.corp.intel.com (HELO [10.251.85.132]) ([10.251.85.132]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Nov 2020 01:31:43 -0800 From: Ferruh Yigit To: Guoyang Zhou , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko Cc: bluca@debian.org, cloud.wangxiaoyun@huawei.com, luoxianjun@huawei.com, yin.yinshi@huawei.com, luojiachen@huawei.com, chenlizhong@huawei.com, zhaohui8@huawei.com, chenchanghu@huawei.com References: Message-ID: Date: Tue, 24 Nov 2020 09:31:39 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 0/2] remove some limitations and operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/23/2020 4:09 PM, Ferruh Yigit wrote: > On 11/23/2020 1:12 PM, Guoyang Zhou wrote: >> The maximum number of queues on the chip can be any value greater >> than 0, it does not have to be the power of two, and remove the >> operation of optical modules in the link function. >> >> -- >> v1: >>    - remove the limitation for max queue num >>    - remove the operation of optical modules in the link function >> >> Guoyang Zhou (2): >>    net/hinic/base: remove the limitation for max queue num >>    net/hinic: remove the operation of optical modules >> > > Hi Guoyang, > > How critical is this set, can you please describe the impact of the fixes? > > If they are not critical, let's postpone them to next release, since the release > is a few days away. > Hi Guoyang, I can see that a v2 has been sent but it is still not clear if you are OK to defer the patches, can you please share your thoughts on it? Thanks, ferruh > btw, both patches has [1] as a fixed patch, but that patch looks unrelated with > both, that patch only cleans up the uninit/destroy path. > Can you please elaborate why that patch is fixed? > > As far as I can see the condition removed in first patch introduced in v19.08 > ([2]) and the calls in second patch added in v19.11 ([3]). > > > > [1] > Fixes: 511b7371d32b ("net/hinic: fix hugepage memory leaks") > > > [2] > Fixes: 828d3e15a9dc ("net/hinic/base: support context and work queue") > > [3] > Fixes: 54ac33869932 ("net/hinic: set link down and up")