From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 97770A052A;
	Tue,  2 Feb 2021 12:41:35 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1D081240272;
	Tue,  2 Feb 2021 12:41:35 +0100 (CET)
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by mails.dpdk.org (Postfix) with ESMTP id 32FD724026F
 for <dev@dpdk.org>; Tue,  2 Feb 2021 12:41:33 +0100 (CET)
IronPort-SDR: 8/p3vVw7F1UGey4riAdOBgkIuTuN72JZgNL+gdeyqGeRQqvetcz2iDSn/bc8h2jWFewEpUh54i
 F5RA9p8lvQwA==
X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="160604983"
X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="160604983"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 03:41:32 -0800
IronPort-SDR: PZTcVDxCa5xp8CozKNU9fY9h4aY3MTlo6+CUzYyOr8WHoZvec6CPKfCSBeeu76PaIS/bdTV+pM
 Y/6OPrw7XtzQ==
X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391424335"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112])
 ([10.213.226.112])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 02 Feb 2021 03:41:31 -0800
To: Hemant Agrawal <hemant.agrawal@nxp.com>, dev@dpdk.org
References: <20210120142723.14090-1-hemant.agrawal@nxp.com>
 <20210120142723.14090-7-hemant.agrawal@nxp.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f232001b-a1e7-2576-a940-3793470537a5@intel.com>
Date: Tue, 2 Feb 2021 11:41:30 +0000
MIME-Version: 1.0
In-Reply-To: <20210120142723.14090-7-hemant.agrawal@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 6/7] net/dpaa2: add traffic management driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/20/2021 2:27 PM, Hemant Agrawal wrote:
> From: Gagandeep Singh <g.singh@nxp.com>
> 
> Add basic support for scheduling and shaping on dpaa2
> platform.
> 
> HW supports 2 level of scheduling and shaping.
> However the current patch only support single level.
> 
> Signed-off-by: Gagandeep Singh <g.singh@nxp.com>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>   drivers/net/dpaa2/dpaa2_ethdev.c    |  14 +-
>   drivers/net/dpaa2/dpaa2_ethdev.h    |   5 +
>   drivers/net/dpaa2/dpaa2_tm.c        | 626 ++++++++++++++++++++++++++++
>   drivers/net/dpaa2/dpaa2_tm.h        |  32 ++
>   drivers/net/dpaa2/mc/dpni.c         | 313 +++++++++++++-
>   drivers/net/dpaa2/mc/fsl_dpni.h     | 210 +++++++++-
>   drivers/net/dpaa2/mc/fsl_dpni_cmd.h |  59 ++-
>   drivers/net/dpaa2/meson.build       |   3 +-
>   8 files changed, 1257 insertions(+), 5 deletions(-)
>   create mode 100644 drivers/net/dpaa2/dpaa2_tm.c
>   create mode 100644 drivers/net/dpaa2/dpaa2_tm.h

Can you please update the documentation and the release notes for the traffic 
management support?

And this is relative big chunk of code, and taken into account that it has been 
sent after -rc1, can you please confirm you want to get it for the -rc3, which 
won't give much time to test before the release?
Or we can postpone it to next release to be on the safe side.