From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 8ED792C19 for ; Wed, 25 Apr 2018 11:14:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 02:14:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="36889723" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.109]) ([10.237.220.109]) by orsmga006.jf.intel.com with ESMTP; 25 Apr 2018 02:14:19 -0700 To: Arnon Warshavsky , thomas@monjalon.net, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Cc: dev@dpdk.org References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-9-git-send-email-arnon@qwilt.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 25 Apr 2018 10:14:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1524608213-2080-9-git-send-email-arnon@qwilt.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 08/11] eal: replace rte_panic instances in interrupts thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 09:14:23 -0000 On 24-Apr-18 11:16 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > Thread function removes the noreturn attribute. > > Signed-off-by: Arnon Warshavsky > --- Just a general comment - i'm not too familiar with this code, but it looks like all of these failures will only happen on thread init. Can we make sure it starts? You can use similar approach to Olivier's (recently merged) thread affinity patches, with pthread barriers etc. to ensure the thread has initialized properly, pthread_cancel() it if it didn't, and return -1 on thread init. -- Thanks, Anatoly