From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 001E5A0A0A; Thu, 3 Jun 2021 03:44:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7085C4067A; Thu, 3 Jun 2021 03:44:34 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 172E44013F for ; Thu, 3 Jun 2021 03:44:32 +0200 (CEST) Received: from dggeme765-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FwT8x6fXJzWqMD; Thu, 3 Jun 2021 09:39:45 +0800 (CST) Received: from [127.0.0.1] (10.69.27.114) by dggeme765-chm.china.huawei.com (10.3.19.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 3 Jun 2021 09:44:29 +0800 To: References: <1618571071-5927-1-git-send-email-tangchengchang@huawei.com> <1619171202-28486-1-git-send-email-tangchengchang@huawei.com> CC: , , , , From: Chengchang Tang Message-ID: Date: Thu, 3 Jun 2021 09:44:29 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1619171202-28486-1-git-send-email-tangchengchang@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.69.27.114] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggeme765-chm.china.huawei.com (10.3.19.111) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 0/2] add Tx prepare support for bonding device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi,all Any comments to these patches? On 2021/4/23 17:46, Chengchang Tang wrote: > This patch set add Tx prepare for bonding device. > > Currently, the bonding driver has not implemented the callback of > rte_eth_tx_prepare function. Therefore, the TX prepare function of the > slave devices will never be invoked. When hardware offloading such as > CKSUM and TSO are enabled for some drivers, tx_prepare needs to be used > to adjust packets (for example, set correct pseudo packet headers). > Otherwise, related offloading fails and even packets are sent > incorrectly. Due to this limitation, the bonded device cannot use these > HW offloading in the Tx direction. > > Because packet sending algorithms are numerous and complex in bond PMD, > it is hard to design the callback for rte_eth_tx_prepare. In this > patchset, the tx_prepare callback of bonding PMD is not implemented. > Instead, rte_eth_tx_prepare has been called in tx_burst callback. In > this way, all tx_offloads can be processed correctly for all NIC devices. > It is the responsibility of the slave PMDs to decide when the real > tx_prepare needs to be used. If tx_prepare is not required in some cases, > then slave PMDs tx_prepare pointer should be NULL and rte_eth_tx_prepare() > will be just a NOOP. That is, the effectiveness and security of tx_prepare > and its impact on performance depend on the design of slave PMDs. > > And configuring Tx offloading for bonding is also added in this patchset. > This solves the problem that we need to configure slave devices one by one > when configuring Tx offloading. > > Chengchang Tang (2): > net/bonding: support Tx prepare for bonding > net/bonding: support configuring Tx offloading for bonding > > drivers/net/bonding/rte_eth_bond.h | 1 - > drivers/net/bonding/rte_eth_bond_pmd.c | 41 ++++++++++++++++++++++++++++++---- > 2 files changed, 37 insertions(+), 5 deletions(-) > > -- > 2.7.4 > > > . >