From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D217245957; Tue, 10 Sep 2024 15:41:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BF1742E57; Tue, 10 Sep 2024 15:41:29 +0200 (CEST) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mails.dpdk.org (Postfix) with ESMTP id 9484F402AB for ; Tue, 10 Sep 2024 15:41:26 +0200 (CEST) Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a8a7929fd64so722876466b.0 for ; Tue, 10 Sep 2024 06:41:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725975686; x=1726580486; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=vufHjTk/lz4LMjmbkDD93Fedzo3OH7m3ZV+6XIQnL1k=; b=WnV00xNsQRyK6nMUG7uGeUnssRfRwT5r5qheRs7ER8spBW1M7NCa6NLJmUPfjalI92 2xraW5VKj8Q4OPJzyH+ue1xhwIP/r+40cBWdVojKYslBKza5bwgZtfSWYbvCsOsWofug P9woyi29F/KwDTs34Uiq0GRVdQwFxBTzI6Mh7Bh1S7RUdkk+8TFU9jy97PwacqbXnIWA QHQFs90S5RLsXg1yCcSxQNq+TWgOYPgraZTxh1sXdyw4mCRl/mrAgNB0Jn4Ab6J9beJZ m3KcTOFVnWwPtS31wFk3ABfR6S2D4pulcqR7Q1Ym+BHqowzmHjwtG58CKT74sj4JKWvj z9sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725975686; x=1726580486; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vufHjTk/lz4LMjmbkDD93Fedzo3OH7m3ZV+6XIQnL1k=; b=pc3GGXT4DWE57/wCYbOmqNdRHJfs081pVhpxfYSREkIqOi7CSR+93XIZZyQ/yppaQL kvhf2XsqP+e0efKQg3TWk3QghU1dtV4IqRd0kA9T/lr/VkvviZKRWePKMDICig3qd5r9 ZcdxEDqgvFjGmUBcrOF4EGRvkipigeB5PB40CdAqS6lqdXwauVAvM3BrMP45DQ5ORO8S /p8zAnmJOA/RxPvze/V3cCkHBMJB8geZS3gOoF2xjpJuKJALlfjEJGOZEcTUaxqRimg5 3xMErwFVoJSMRfs2wEDylKvIuyN+zBBRsjLXvHa0s9lbG60OBPWhTFnCT50PuVsPicmD UMlQ== X-Gm-Message-State: AOJu0Yxk55FYuHoyj2kpdEM44o/QnlGw+oOvKmLRWxxHK/URFTO91ofN vUrNETz0caRtR9x9mujfUhz22Vuh7yKUO+KBwcPsLyUl4q0d7Xq6x2I4+aW5qkY= X-Google-Smtp-Source: AGHT+IFvy6uqJK6UcRgq/BS/Gd5r/iHO5IeG6eotolXsgN0icAS8LoDfvD/G6GGiDIuaNaT9uR9qmA== X-Received: by 2002:a17:907:7ea9:b0:a86:8f8f:4761 with SMTP id a640c23a62f3a-a8ffab29500mr79537566b.25.1725975686088; Tue, 10 Sep 2024 06:41:26 -0700 (PDT) Received: from [192.168.0.113] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25d5dc8csm483703566b.206.2024.09.10.06.41.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 06:41:25 -0700 (PDT) Message-ID: Date: Tue, 10 Sep 2024 15:41:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] dts: Self-Discovering Architecture Change To: Nicholas Pratte , probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-8-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240705171341.23894-8-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5. 7. 2024 19:13, Nicholas Pratte wrote: > The 'arch' attribute in the conf.yaml is unnecessary, as this can be > readily discovered within the constructor of any given node. Since OS is > determined within user configuration, finding system arch can be done > both reliably and easily within the framework. > > For Linux/Posix systems, the 'uname' command is used to determine system > architecture. I believe that this is posix-standard and utilizes a > standardized output. From what I can tell, uname is it POSIX compliant. Let's reword this to remove the uncertainty. > diff --git a/dts/framework/testbed_model/os_session.py b/dts/framework/testbed_model/os_session.py > index 79f56b289b..02277eee1f 100644 > --- a/dts/framework/testbed_model/os_session.py > +++ b/dts/framework/testbed_model/os_session.py > @@ -342,6 +342,14 @@ def get_node_info(self) -> NodeInfo: > Node information. > """ > > + @abstractmethod > + def get_arch_info(self) -> str: I'd rename this to just get_arch(), as get_arch_info implies we're getting more than just a string representation of the archirecture. > + """Discover CPU architecture of the remote host. The CPU architecture