DPDK patches and discussions
 help / color / mirror / Atom feed
From: Balazs Nemeth <bnemeth@redhat.com>
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
Date: Wed, 23 Dec 2020 15:15:49 +0100	[thread overview]
Message-ID: <f25988d5c0f726dd545c76bd74825c5b910dd0e8.1608732916.git.bnemeth@redhat.com> (raw)

When calling rte_eth_promiscuous_enable(port_id) followed by
rte_eth_allmulticast_enable(port_id), the port is not in promisc mode
anymore. This patch ensures that promisc mode takes precedence over
allmulticast mode fixing the regression introduced by b10231aed1ed.

Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
 drivers/net/qede/qede_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 549013557..3bec62d82 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1885,6 +1885,8 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev)
 	enum _ecore_status_t ecore_status;

+	if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1)
 	ecore_status = qed_configure_filter_rx_mode(eth_dev, type);

 	return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN;

             reply	other threads:[~2020-12-23 14:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 14:15 Balazs Nemeth [this message]
2021-01-04 12:44 ` Igor Russkikh
2021-01-04 14:17   ` [dpdk-dev] [EXT] " Rasesh Mody
2021-01-12  4:50     ` Jerin Jacob
2021-01-12  5:55       ` Rasesh Mody
2021-01-14 13:29         ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f25988d5c0f726dd545c76bd74825c5b910dd0e8.1608732916.git.bnemeth@redhat.com \
    --to=bnemeth@redhat.com \
    --cc=dev@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).