From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAB59A0526; Thu, 9 Jul 2020 01:04:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 690681E546; Thu, 9 Jul 2020 01:04:11 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id E946B1E545 for ; Thu, 9 Jul 2020 01:04:09 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20200708230409euoutp027f92bfa9bdd5741eeaf664140dcc271d~f6W1jiq262829928299euoutp02S for ; Wed, 8 Jul 2020 23:04:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20200708230409euoutp027f92bfa9bdd5741eeaf664140dcc271d~f6W1jiq262829928299euoutp02S DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1594249449; bh=k1yuVXR4pnCj+q7gESMomVWuktliSNzP8jiOccn1a0c=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=jqEDNodmqfYD8s5fdY/sgNVzNUoNkvBPax9OUccucIw1NP83gT5d7lg5UNIpj9aWP qncestq1ogl9MjACRuWqdvLi3CyLdnvxCPJMsayURD9wGBcccaJZg9oDzn+0YtrUTk +023qloew3T0czfiGkfQ1E9tM72VQvrRdpMelric= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20200708230408eucas1p1544a169e31e963d2017929fea775d71a~f6W0qTkMg0141501415eucas1p1j; Wed, 8 Jul 2020 23:04:08 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 4F.FC.05997.8E0560F5; Thu, 9 Jul 2020 00:04:08 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20200708230407eucas1p1c4f477af3b3b231a280dc3c15439f11b~f6W0OGcWk3266132661eucas1p1p; Wed, 8 Jul 2020 23:04:07 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200708230407eusmtrp143d476f6b4206aa777891853c34be2d2~f6W0Nl4od1168411684eusmtrp1j; Wed, 8 Jul 2020 23:04:07 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-0e-5f0650e8d253 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 03.A2.06017.7E0560F5; Thu, 9 Jul 2020 00:04:07 +0100 (BST) Received: from [106.210.88.70] (unknown [106.210.88.70]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20200708230407eusmtip25e3e13eb4cd27ea34a567725b8995050~f6Wz3mDge2409024090eusmtip2F; Wed, 8 Jul 2020 23:04:07 +0000 (GMT) To: Kevin Traynor , dev@dpdk.org Cc: david.marchand@redhat.com From: Lukasz Wojciechowski Message-ID: Date: Thu, 9 Jul 2020 01:04:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200612120959.25626-1-ktraynor@redhat.com> Content-Transfer-Encoding: 8bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42LZduzned0XAWzxBse3sFlsX9HFZvHu03Ym i7WHPrA7MHv8WrCU1eP9vqtsAUxRXDYpqTmZZalF+nYJXBkHz+5jLmjnq9jeeJmpgXEqdxcj J4eEgInEjD0nWLsYuTiEBFYwSrzevpQRwvnCKLH72X2ozGdGifV3tjN1MXKAtey7LwMRX84o ca+1hRnCecsoMWvnIlaQImEBR4kzx0tAVogImErcOnmbCcRmFpCVuPlnMiOIzSZgK3Fk5ldW EJtXwE3iycZOdhCbRUBFYvmVzWC2qECcxPqX25kgagQlTs58wgJicwpYShz/8IIFYqa8RPPW 2cwQtrjErSfzmUDukRD4zyYxd9cfRog/XSSW/1/FDGELS7w6voUdwpaROD25hwWiYRujxNXf PxkhnP2MEtd7V0BVWUsc/vebDeQzZgFNifW79CHCjhJtZw+xQUKFT+LGW0GII/gkJm2bzgwR 5pXoaBOCqNaTeNozlRFm7Z+1T1gmMCrNQvLaLCTvzELyziyEvQsYWVYxiqeWFuempxYb5aWW 6xUn5haX5qXrJefnbmIEpo/T/45/2cG460/SIUYBDkYlHt4Xm1jjhVgTy4orcw8xSnAwK4nw Op09HSfEm5JYWZValB9fVJqTWnyIUZqDRUmc13jRy1ghgfTEktTs1NSC1CKYLBMHp1QDY16p 6p/n4gJCybwqpeY3Av9E+9pwi19evvTW02m2h3cVh13b/eyq+/+12flrmpQ6VmUuiRH1v/37 ZKhQ2P39Hd2753veyTy2vWBf89kfb9axKJx4WfNbj7ORVWzByrhjertup2879FAh9iy/lHJO 2cpYgR7riJcWu3Wkyj9XSEbfPeC95eK6fUosxRmJhlrMRcWJAO/L1VQbAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBIsWRmVeSWpSXmKPExsVy+t/xe7rPA9jiDdquaFhsX9HFZvHu03Ym i7WHPrA7MHv8WrCU1eP9vqtsAUxRejZF+aUlqQoZ+cUltkrRhhZGeoaWFnpGJpZ6hsbmsVZG pkr6djYpqTmZZalF+nYJehkHz+5jLmjnq9jeeJmpgXEqdxcjB4eEgInEvvsyXYxcHEICSxkl Zn2YwQ4Rl5H4cEmgi5ETyBSW+HOtiw3EFhJ4zSjRONcNpERYwFHizPESkLCIgKnErZO3mUBs ZgFZiZt/JjNCjOxhlFhz/RJYgk3AVuLIzK+sIDavgJvEk42d7CA2i4CKxPIrm8FsUYE4ieVb 5rND1AhKnJz5hAXE5hSwlDj+4QULxAIziXmbHzJD2PISzVtnQ9niEreezGeawCg0C0n7LCQt s5C0zELSsoCRZRWjSGppcW56brGRXnFibnFpXrpecn7uJkZgrGw79nPLDsaud8GHGAU4GJV4 eF9sYo0XYk0sK67MPcQowcGsJMLrdPZ0nBBvSmJlVWpRfnxRaU5q8SFGU6DnJjJLiSbnA+M4 ryTe0NTQ3MLS0NzY3NjMQkmct0PgYIyQQHpiSWp2ampBahFMHxMHp1QD46H7gQLTr3TnT9hy cWnGXPnCTLt6r3zJpL6t6m/Ml823ifnenjVh/zq5i0f4P/s9mGbpMK2w8rTIB52UalWBHMZw +ZgPuyeo6ai7L+iIOfH/4Vu510byWnof+Bjb9lruMXou/DN6v8i2f0t9T9w48a+qYeKU8yEi nlEnDqkm5t6wZDOsPLJIWImlOCPRUIu5qDgRABHW2SirAgAA X-CMS-MailID: 20200708230407eucas1p1c4f477af3b3b231a280dc3c15439f11b X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200612121031eucas1p2e5d39ccf4ebc398d4b4655fb9f5ac6e1 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200612121031eucas1p2e5d39ccf4ebc398d4b4655fb9f5ac6e1 References: <20200612120959.25626-1-ktraynor@redhat.com> Subject: Re: [dpdk-dev] [PATCH] test/eal: check invalid cpu value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" W dniu 12.06.2020 o 14:09, Kevin Traynor pisze: > When using --lcores option, CPU_SETSIZE allows a range of > 0-1023. Check it is not being exceeded. > > Signed-off-by: Kevin Traynor > --- > app/test/test_eal_flags.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index 4ee809e3d..044cc1c59 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -528,4 +528,7 @@ test_missing_c_flag(void) > "--lcores", > "0-1,2@(5-7),(3-5)@(0,2),(0,6),7"}; > + /* check an invalid cpu value >= CPU_SETSIZE */ > + const char * const argv30[] = { prgname, prefix, mp_flag, > + "--lcores", "3@1024" }; > The proper cpu values are in range 0-CPU_SETSIZE, but the CPU_SETSIZE is not always equal to 1024 (currently it is on Linux). Check lib/librte_eal/windows/include/sched.h:17 : #ifndef CPU_SETSIZE #define CPU_SETSIZE RTE_MAX_LCORE #endif so to make your patch better, you can use CPU_SETSIZE value directly: const char * const argv30[] = { prgname, prefix, mp_flag, "--lcores", "3@" RTE_STR(CPU_SETSIZE) }; > if (launch_proc(argv2) != 0) { > @@ -577,5 +580,6 @@ test_missing_c_flag(void) > launch_proc(argv24) == 0 || launch_proc(argv25) == 0 || > launch_proc(argv26) == 0 || launch_proc(argv27) == 0 || > - launch_proc(argv28) == 0) { > + launch_proc(argv28) == 0 || launch_proc(argv30) == 0) { > + > printf("Error - " > "process ran without error with invalid --lcore flag\n"); Best regards -- Lukasz Wojciechowski Principal Software Engineer Samsung R&D Institute Poland Samsung Electronics Office +48 22 377 88 25 l.wojciechow@partner.samsung.com