From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH 0/6] remove unncessary void cast
Date: Mon, 11 Sep 2017 14:32:59 +0100 [thread overview]
Message-ID: <f27a4aba-50a0-eef0-8ee0-c8335c7191f9@intel.com> (raw)
In-Reply-To: <37f971b8-cae3-f486-a6d4-ff00bfab99a6@intel.com>
On 9/11/2017 1:44 PM, Ferruh Yigit wrote:
> On 8/23/2017 4:44 PM, Stephen Hemminger wrote:
>> There are many places that cast away the return value from
>> rte_memcpy(). This was a common practice in the Unix BSD days because
>> lint would complain about unused return values, but it is not done
>> in modern Linux style because it clutters the code.
>>
>> Maybe it was done for some Coverity warnings. If so, that issue
>> should be addressed with Coverity overrides not more code clutter.
>>
>> Stephen Hemminger (6):
>> testpmd: remove unnecessary void casts
>> bnx2x: remove unnecssary void cast of rte_memcpy
>> sfc: remove unnecessary cast of rte_memcpy
>> e1000: remove unnecessary cast of rte_memcpy
>> i40e: remove unnecessary cast of rte_memcpy
>> ixgbe: remove unnecessary cast of rte_memcpy
>
> My concern is if coverity complains about return value not checked and
> someone starts fixing them adding void casts back.
>
> So I will evaluate the patchset for next-net, so that I can run coverity
> on them before merged into main tree, and see the result.
Coverity result on latest next-net (including this patchset)
https://scan.coverity.com/projects/dpdk-next-net
rte_memcpy() return value not checked is not seen as an issue, so this
set is OK.
next prev parent reply other threads:[~2017-09-11 13:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:44 Stephen Hemminger
2017-08-23 15:44 ` [dpdk-dev] [PATCH 1/6] testpmd: remove unnecessary void casts Stephen Hemminger
2017-09-04 11:39 ` Rybalchenko, Kirill
2017-09-07 8:36 ` Wu, Jingjing
2017-09-11 12:44 ` Ferruh Yigit
2017-08-23 15:44 ` [dpdk-dev] [PATCH 2/6] bnx2x: remove unnecssary void cast of rte_memcpy Stephen Hemminger
2017-09-04 11:50 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 3/6] sfc: remove unnecessary " Stephen Hemminger
2017-09-04 12:39 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 4/6] e1000: " Stephen Hemminger
2017-09-04 12:40 ` Rybalchenko, Kirill
2017-08-23 15:44 ` [dpdk-dev] [PATCH 5/6] i40e: " Stephen Hemminger
2017-09-04 12:45 ` Rybalchenko, Kirill
2017-09-09 3:24 ` Wu, Jingjing
2017-08-23 15:44 ` [dpdk-dev] [PATCH 6/6] ixgbe: " Stephen Hemminger
2017-09-04 12:49 ` Rybalchenko, Kirill
2017-09-11 12:44 ` [dpdk-dev] [PATCH 0/6] remove unncessary void cast Ferruh Yigit
2017-09-11 13:32 ` Ferruh Yigit [this message]
2017-09-11 13:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27a4aba-50a0-eef0-8ee0-c8335c7191f9@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).