From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id A002EA04BA;
Wed, 7 Oct 2020 12:41:30 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E2DB84C9D;
Wed, 7 Oct 2020 12:41:28 +0200 (CEST)
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
by dpdk.org (Postfix) with ESMTP id D31472BC7
for <dev@dpdk.org>; Wed, 7 Oct 2020 12:41:26 +0200 (CEST)
IronPort-SDR: nkri+JYmR9cVBbFKH4hQOhXMPfpjsxRENpwa8rfbh2N5DBHIZ8TgOd6OvYVAWZqTQ6DJVxel+U
rnacfHM0nPIA==
X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="226480721"
X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="226480721"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga005.jf.intel.com ([10.7.209.41])
by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
07 Oct 2020 03:41:24 -0700
IronPort-SDR: bA0H7fRR0iVfpRKlgjv/jgn449fzrJeuTOrOsDL5cz1gV1nTwLmsfA9E9hstwi78VxV54+b6lE
Z5pBY4UmE6UA==
X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="527892431"
Received: from dwdohert-mobl.ger.corp.intel.com (HELO [10.213.210.10])
([10.213.210.10])
by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
07 Oct 2020 03:41:22 -0700
To: David Marchand <david.marchand@redhat.com>,
Adam Dybkowski <adamx.dybkowski@intel.com>
Cc: dev <dev@dpdk.org>, "Trahe, Fiona" <fiona.trahe@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Arek Kusztal <arkadiuszx.kusztal@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, Ray Kinsella <mdr@ashroe.eu>
References: <20200814095942.1726-1-adamx.dybkowski@intel.com>
<CAJFAV8wYYdsONndg766839VsDYe2aTH4btNwn_6FCBBPOco_sw@mail.gmail.com>
From: "Doherty, Declan" <declan.doherty@intel.com>
Message-ID: <f294de5c-7c38-fdbc-c899-f7f0f561cd96@intel.com>
Date: Wed, 7 Oct 2020 11:41:19 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <CAJFAV8wYYdsONndg766839VsDYe2aTH4btNwn_6FCBBPOco_sw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] cryptodev: revert ABI compatibility for
ChaCha20-Poly1305
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 06/10/2020 1:32 PM, David Marchand wrote:
> For the title, I would suggest: "cryptodev: remove v20 ABI compatibility"
>
> You did this change using a revert, but still, we can avoid restoring
> coding style issues, see nits below.
>
>
> On Fri, Aug 14, 2020 at 12:00 PM Adam Dybkowski
> <adamx.dybkowski@intel.com> wrote:
>> This reverts commit a0f0de06d457753c94688d551a6e8659b4d4e041 as the
>> rte_cryptodev_info_get function versioning was a temporary solution
>> to maintain ABI compatibility for ChaCha20-Poly1305 and is not
>> needed in 20.11.
>>
...
>>
>> int
>> rte_cryptodev_callback_register(uint8_t dev_id,
>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h b/lib/librte_cryptodev/rte_cryptodev.h
>> index 7b3ebc20f..26abd0c52 100644
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -219,14 +219,6 @@ struct rte_cryptodev_asym_capability_idx {
>> * - Return NULL if the capability not exist.
>> */
>> const struct rte_cryptodev_symmetric_capability *
>> -rte_cryptodev_sym_capability_get_v20(uint8_t dev_id,
>> - const struct rte_cryptodev_sym_capability_idx *idx);
>> -
>> -const struct rte_cryptodev_symmetric_capability *
>> -rte_cryptodev_sym_capability_get_v21(uint8_t dev_id,
>> - const struct rte_cryptodev_sym_capability_idx *idx);
>> -
>> -const struct rte_cryptodev_symmetric_capability *
>> rte_cryptodev_sym_capability_get(uint8_t dev_id,
>> const struct rte_cryptodev_sym_capability_idx *idx);
>>
>> @@ -789,33 +781,9 @@ rte_cryptodev_stats_reset(uint8_t dev_id);
>> * the last valid element has it's op field set to
>> * RTE_CRYPTO_OP_TYPE_UNDEFINED.
>> */
>> -
>> -void
>> +extern void
> Nit: no need for extern.
Hey David, I think the cryptodev API consistently uses extern on nearly
all it's function declarations. I'd proposed we do a separate patchset
which removes extern on all function declarations to make it more
consistent with the rest of DPDKs libraries.
> /**
> * Register a callback function for specific device id.
...
> Thanks for working on this.
> Note to others watching ABI, with this, it should be the last patch
> about DPDK_20 ABI.
>
>