From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2AD427CB6 for ; Thu, 14 Sep 2017 16:41:21 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Sep 2017 07:41:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,393,1500966000"; d="scan'208";a="311674002" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga004.fm.intel.com with ESMTP; 14 Sep 2017 07:41:19 -0700 To: Zhiyong Yang , dev@dpdk.org Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, david.hunt@intel.com References: <20170904055734.21354-1-zhiyong.yang@intel.com> <20170909144727.46388-1-zhiyong.yang@intel.com> <20170909144727.46388-4-zhiyong.yang@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 14 Sep 2017 15:41:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170909144727.46388-4-zhiyong.yang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] examples: increase port_id range X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Sep 2017 14:41:22 -0000 On 9/9/2017 3:47 PM, Zhiyong Yang wrote: > Modify port_id related code in examples accordingly since port_id > definition in lib and pmd changes. > > Fix some original checkpatch issues and remove some unnecessary > cast at the same time. > > Signed-off-by: Zhiyong Yang > --- <...> > > diff --git a/doc/guides/rel_notes/release_17_11.rst b/doc/guides/rel_notes/release_17_11.rst > index 170f4f916..98fd7cb23 100644 > --- a/doc/guides/rel_notes/release_17_11.rst > +++ b/doc/guides/rel_notes/release_17_11.rst > @@ -41,6 +41,10 @@ New Features > Also, make sure to start the actual text at the margin. > ========================================================= > > +* **Extended port_id range from uint8_t to uint16_t.** > + > + Extended port_id range from 8 bits to 16 bits in order to support more than > + 256 ports in dpdk. > > Resolved Issues > --------------- There was a LIBABIVER update comment in patch 1/4, let me continue it here. First lets extract documentation on its own patch, instead of being part of "examples" update. And update it a little more: 1- Remove deprecation notice. Each patch implements a deprecation notice also should remove the notice. rel_notes/deprecation.rst should be updated to remove port_id related paragraph. 2- LIBABIVER values of increased libraries should be increased. LIBABIVER is defined in each library Makefile, and set to the value of current version of the library. The libraries breaking ABI/API should increase this by one. So for this patch, following libraries should be updated: drivers/net/bnxt drivers/net/bonding drivers/net/i40e drivers/net/ixgbe lib/librte_ether lib/librte_bitratestats lib/librte_pdump Please double check the list the libraries in case I missed. And it seems we are breaking more API than initially intended. Should we highlight this more? 3- Document updated library versions in release notes in release notes, there is a "Shared Library Versions" section. This section lists all libraries with their versions, like: " librte_ethdev.so.7" [1] This should be updates as: " librte_ethdev.so.8" [1] It seems I have selected wrong sample :(, there is a mismatch in Makefile LIBABIVER value and release notes version for librte_ethdev, I will send a patch for it. <...>