From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B9FBA056A; Thu, 11 Mar 2021 18:39:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 36759406A3; Thu, 11 Mar 2021 18:39:50 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 6AEA44014D for ; Thu, 11 Mar 2021 18:39:49 +0100 (CET) IronPort-SDR: pk8+gfBB3+N75m84624bKRs19QhcTftxnoVTHaUtpWxeO243Q2uQCwZU3Xb3msTHtAvCVSdDFN TKzH5SsgvZbw== X-IronPort-AV: E=McAfee;i="6000,8403,9920"; a="250073501" X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="250073501" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 09:39:48 -0800 IronPort-SDR: kPUmr/Ak5exvkK56/xEyXvPfCu+HfF707L+i/JXBOrTz9Ag/k54iMwT89suwdR7Et6VKhHmBWw Tr8jKgLWzg+Q== X-IronPort-AV: E=Sophos;i="5.81,241,1610438400"; d="scan'208";a="448352925" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.22.78]) ([10.252.22.78]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Mar 2021 09:39:47 -0800 To: "Min Hu (Connor)" , dev@dpdk.org References: <1615356985-24722-1-git-send-email-humin29@huawei.com> <1615356985-24722-2-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Thu, 11 Mar 2021 17:39:43 +0000 MIME-Version: 1.0 In-Reply-To: <1615356985-24722-2-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 1/9] net/hns3: support runtime config to select IO burst func X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2021 6:16 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > Currently, the driver support multiple IO burst function and auto > selection of the most appropriate function based on offload > configuration. > > Most applications such as l2fwd/l3fwd don't provide the means to > change offload configuration, so it will use the auto selection's io > burst function. > > This patch support runtime config to select io burst function, which > add two config: rx_func_hint and tx_func_hint, both could assign > vec/sve/simple/common. > > The driver will use the following rules to select io burst func: > a. if hint equal vec and meet the vec Rx/Tx usage condition then use > the neon function. > b. if hint equal sve and meet the sve Rx/Tx usage condition then use > the sve function. > c. if hint equal simple and meet the simple Rx/Tx usage condition then > use the simple function. > d. if hint equal common then use the common function. > e. if hint not set then: > e.1. if meet the vec Rx/Tx usage condition then use the neon function. > e.2. if meet the simple Rx/Tx usage condition then use the simple > function. > e.3. else use the common function. > > Note: the sve Rx/Tx usage condition based on the vec Rx/Tx usage > condition and runtime environment (which must support SVE). > > In the previous versions, driver will preferred use the sve function > when meet the sve Rx/Tx usage condition, but in this case driver could > get better performance if use the neon function. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) <...> > + > + rte_kvargs_process(kvlist, "rx_func_hint", &hns3_parse_io_hint_func, > + &rx_func_hint); > + rte_kvargs_process(kvlist, "tx_func_hint", &hns3_parse_io_hint_func, > + &tx_func_hint); > + rte_kvargs_free(kvlist); If you will continue with the device argument method, those should be documented in the device documentation, you can have a section as "Runtime Config Options" and can detail new devargs there. Also 'RTE_PMD_REGISTER_PARAM_STRING' should be added for new devargs.