From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6A39A0542; Wed, 5 Oct 2022 16:20:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E5FA40694; Wed, 5 Oct 2022 16:20:59 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id DAA7340143 for ; Wed, 5 Oct 2022 16:20:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDFscIhLWJiTy4+gxR00CaGDM+bvpbYyCNDIgPRDq7Nlk6nItiz7bmcczc3MPlPz3KzTT9pA/e23NOUM32JPSkSftYJuVYOsvk7BE6+lKgyzWZw2Q4lZqNd7WceC1v1j8QFlsbdKxIyYeKu7jvcM/+ApJYUuzpK/hTVevB6Gz01YntZ7IbFB1P+jZyhheqsv5ppgVw05EV+N2lg5yF1m3CBpU5dODnB0LRBPKb9EXVcBsXJw6SNC+vGmhelmUVRs+mpYU8BGecv7yNU6eblRx/N//opn2vNYOUdh0kOZsDwZqbdSYMpZ97wfMRfB81pHCsGA92EZqF8iBH3JG1MxwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=22fjie4gPloWtX5/UHNjmbazESVLfU5cQog0wKdSXG4=; b=IiSpMB06UgGIXPV9IbDQCz5otSLJWRifhnO1O0M52U6rVJ4Jnl+5c9I0iY1iTF3e6ZPmLl2FgA8EUOwTS+Ke9mnq0mP2/8pQG4OgeQJxGXWyesvAGkQ7jWKJ0P0R8ZCM3J+HVr9H1NDhDAbxGJAkmfQc4TgPl8itLbwLsxrhoi8TQwgbLjpGYjAkqZwN/A+uUaJCc9M0ryP5GVzlrZSOh+K4Ja50fyaJ6QuCSvjXxDus48u4r3CEWIpDkakE8/9mJQ9OtseJpsSfczSvXcgGn/JcUb6bZ4cYUS4NLmOWBpSQtjQHX/2FaHii40IUsEJAXVcmNxyKqdqj/3KGuhl/gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22fjie4gPloWtX5/UHNjmbazESVLfU5cQog0wKdSXG4=; b=ZLlps0wemiir0zjslkvjmZAsiE5znEVBCJQDjiwGgtY6f/rzw9mcXJaryQl3GSds4k5fJG28zLyMnaa+L0PUsgupBU+TkAaE/LFFRTuJ0QpEbumTwO4QJYizXUzvfjuyDqO+Xqv+VQaT4wYfEGORPHHVaCKEW0vrzEKcIY2bOUw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH7PR12MB5688.namprd12.prod.outlook.com (2603:10b6:510:130::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.32; Wed, 5 Oct 2022 14:20:55 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::d07a:463f:6f93:337f%7]) with mapi id 15.20.5676.032; Wed, 5 Oct 2022 14:20:54 +0000 Message-ID: Date: Wed, 5 Oct 2022 15:20:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH 06/15] net/dpaa: support ESP packet type in packet parsing Content-Language: en-US To: Gagandeep Singh References: <20220928052516.1279442-1-g.singh@nxp.com> <20220928052516.1279442-7-g.singh@nxp.com> From: Ferruh Yigit Cc: dev@dpdk.org In-Reply-To: <20220928052516.1279442-7-g.singh@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0474.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a8::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH7PR12MB5688:EE_ X-MS-Office365-Filtering-Correlation-Id: 5ecfa8c4-b468-49e5-d91f-08daa6dcd063 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hfIqdp08z8rZssWviHkqiaSuKLeijcLCRjdn4emhzDWIadFyP0zEaAECvVT3wGJ9E+qtU+n33svIWc2U5nnfRH/YDFudGBrS8hNXmw+qdzT5jEaTaDVtx+FhrRJEW9G9VR6sF4G6UcAVjwfCHy7R8d/hFrL3NC2WgeHHW4ZhB4DRxj9QzgELb6QcliV2lFA7V6e5lK5s0SxgY6XqZfydueuS7z6XGJK1r2ujLTU7skr0csj+zNAoZvq5jRL4MXqm3K9l/iI4e0FL+SuR2KS1eUjELPsXZrOOi2QIHTpKgdPTedgGR+ZwCNJYUCpuqgw8t7wIC9IJOuBsim8WzTnmUBq435xxLr2UGaAPodxUJh5ufK3rYtgD4/nZAKmcMif3ur5CDmH9WLdhR4wlRkyysiFlG7HzMS4OfnVWCPvL+tj3iIPjyJ5Qu6YVojOT7jJrHHA6wvvWVFbLCzcXl0k03T1fkyxAjA94fQaw+k9lwPgWMMveKTmFXi1Y9b39Kx2io2Z/RSMSvQpP/l5F8vK0eKARyFozEvH0fMT8QbiM+P1vSKizutQ+1nbVqX0phiM4LlwWGE40NeX+nd3a3g+NROhLb/uVDPrf7Gh6P+/DFyADaKJmFbou+YSFGc20kN6waoLipEKqk0AK/x4LHofDBw0Truw5jTd00v5be68qmq231vrWZeRriIFVlTa+Xy1QcJsJRI7yle83/CSPcMd6k50DVUx8PqjRa4QI8xkZRfmIrtAgCIjTgt95QAU8c28jYud1bZq4hixfip/8X0Dc4Z3u4i82JZIV3McOt2s2Acw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(376002)(39860400002)(396003)(366004)(346002)(136003)(451199015)(31686004)(8676002)(4326008)(186003)(2616005)(31696002)(478600001)(41300700001)(6486002)(66946007)(5660300002)(66476007)(66556008)(38100700002)(26005)(6916009)(83380400001)(316002)(6512007)(6666004)(6506007)(86362001)(8936002)(44832011)(36756003)(53546011)(2906002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2U4WTJEM21QaWdlYzNzK3RrMWFQbDFxMU1kY3pyckNpSDAwbUFxZFhqTlNv?= =?utf-8?B?dGk3aFM3cjFCNXhVUkFoMStRTEFGbTNyRThYdDB0Q2NNRWRRRjdwL1VZWlNP?= =?utf-8?B?L0RVVzZpc09NbWptNERZcjZWTTdqVXNmc3IrSWFiMjlsQ0xFVnFzamxQSVIy?= =?utf-8?B?VExNaTIrMG9CT1VUeVI1aFNBVzBvVmErRVVGQUJaUG1Tb0pFZTY2UDhCcTRv?= =?utf-8?B?NnpVczJnZ0tZL2wxWUxaUGVGZjUxSmd3dkVZbXB4WTZhVFZZUHFuOGJzTUdG?= =?utf-8?B?STB6eU9ma0JwZ3NwN0R2ckxxYWkvTGRnc3FrTEdhOEVBR04rODdyTlVYeU4x?= =?utf-8?B?Z0JOUjdST3NRRnAvT3AxZEc1dDN0dE9JOEtGeHJyajFYQi9ZYzBnZDBZazh3?= =?utf-8?B?TUlKZWZhVWQzTWR3bS8wcEwwNFVJa3k2T0MxcUxNdlcxeTE2T3Z1azBnbms5?= =?utf-8?B?OWU4TzFRNk9LNnVjbHEyRk4zZm9PV0JIbFcyMWUrY2J5Y1lqcmJEdE51OHpp?= =?utf-8?B?YXpXbERMdkJWUzErdmRiaEhvWmhHRHIzaTVPMXZmckN5YWd0aGpSa29zbnB1?= =?utf-8?B?Y0ZKU3ZYUjlGcTlGNC9Jd0J0NWo3WjRYY3BTNUp6M2JrUHd2OWJYVnZNOGdF?= =?utf-8?B?Y0FYaEdGeFJ1ZmJJWTRNMkRTUGxXbnRRQmJBQU9vVjVJMXBiQk03SFFTeWZ1?= =?utf-8?B?MVNuM2RLQ1ZhcTQwRzBZbGloSEY0MzROZ3ZBZ0Y1ZDNWd0xCU284ai9DTlg2?= =?utf-8?B?VTVRaWcxbWRZM2N6dWhmL1hwQjB2bkY4NmRDZWRzTmE2cXVwUXViUHBabXRS?= =?utf-8?B?MGlMNlAxNGJ3d2dLQ0pnZ0ZWdjN2VTAwT25QSmRHN1FjanphcWNtZXJadmZM?= =?utf-8?B?cFlnOW0yTUxiT2pWT1Rwc1ZUK1M4QURRcGs4cjQ0ZGFrMCthek1vZnRWdUJQ?= =?utf-8?B?d0x1Q3ROT0lBbG1hVjRxYWxhZy9GNFNWTW84YU9RSUhsaWljY3Y3RFpLbGxj?= =?utf-8?B?NlBTNVhSOGpYZDJaWnl4dFZiUWkxclpKU0tGUHE1VmxUNWhYUTArak9oSThx?= =?utf-8?B?S2hpUDhJWjdJOENDaXpIakhMU3ZvcFQ3OURWRWtZZHdLcHVvM0IzTTVDNnVj?= =?utf-8?B?YXR6U3dlVXgyTHYvUW51Q044ckFOZVp5V3FTdEpSaUhwMDZwSkhOOFZTNlJx?= =?utf-8?B?OHpKdW1MczFQZkV4bEdBeXpQQ1JRSjFtSnovOG1nL3ZvU2tSMmJRNzN6VFBB?= =?utf-8?B?bXdGMEdrT2pibFFNa3FUSVhFWW9IWVRJeHdNdnBaTUxjU254bytnSWRBRU5I?= =?utf-8?B?RGlaNTFEdWtoZi9va0ROQ0ozaHcrSVFPR3pvRElSOHRYRnBCOElpbVBaenZF?= =?utf-8?B?bDU2UHh0UTZJU2ZTTE1RaHNuZWpGbmxFaVJUV3ZWdTZuaU1aOUFNRUFnZStQ?= =?utf-8?B?dUszeC9DTW5JakJCekUrSTR6bkVtbUJrQUlwU2YrWGJQNUo4ZFJ1Q0x6YzRn?= =?utf-8?B?eHEzTHNFMWJRWWhRVjJyM2JLQXVMNnhFdnhjMFRBS21iVXFpdzJBY2tUaWt6?= =?utf-8?B?a0o5Qlp2a3hhR0FnRWZpS0d6WktIa2xqZ1k4Qnh6ZkpTVWhUZEZLRDhEV2Jv?= =?utf-8?B?c00zeWYwb0t2NVI4THUzMjM4MVZBUU8xdURCS2pMRE81WVVERWd2M25idEI2?= =?utf-8?B?QjNDcjVFenh4Y2RIamRwWkE4L0QrSG44R2pjZXZrZ0ZEOUZ3KzRYNjUrL1ha?= =?utf-8?B?Z1NYZWpqTHFKVDgzdXhzeHF2ZWQ3cldEY0VwOUowWVRPbGtZUm9vMU1FN2lC?= =?utf-8?B?aHhmRFlsbW05Mmw4cEExcFdBczIvSG9MUmhBRlBhN3ZyRTl3Q3BlREt6M2NH?= =?utf-8?B?aTl1aTJuVllqUlU0clF1M2hBdllMdXhNTG02ODdnNTFmSk5RbnJMUkI0Wmpi?= =?utf-8?B?b0ZQMUxpNGNaVjhVZ21ZeDU5NUdkcm1lVitnc3ppQ0RtREZDalhMYXg0SnJE?= =?utf-8?B?L0tnSFpUVWdJQm5kU3BvYkIxblIxZVoyNkRabVNzY0x5cEJGRml0d2JQTlBt?= =?utf-8?B?MVZYTGRETXRSUFdiN0M2UEdlQjlDTHR5OTI5c0U1M1dRcjlSbURrWTVZVFo4?= =?utf-8?Q?tAR4WwePhSWzWB1iWGfANBxwQ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ecfa8c4-b468-49e5-d91f-08daa6dcd063 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2022 14:20:54.8691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KSIj/oPVTHvszjcdSfxcl7NsXi3OjSxx187vH3D+oxeoi8PHzqESfFkisSrHLU0A X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5688 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/28/2022 6:25 AM, Gagandeep Singh wrote: > Add support of ESP packet type in packet receive path. > > Signed-off-by: Gagandeep Singh > --- > drivers/net/dpaa/dpaa_rxtx.c | 10 ++++++++++ > drivers/net/dpaa/dpaa_rxtx.h | 6 ++++++ > 2 files changed, 16 insertions(+) > > diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c > index 20b75efb63..22205cec30 100644 > --- a/drivers/net/dpaa/dpaa_rxtx.c > +++ b/drivers/net/dpaa/dpaa_rxtx.c > @@ -178,6 +178,16 @@ static inline void dpaa_eth_packet_info(struct rte_mbuf *m, void *fd_virt_addr) > m->packet_type = RTE_PTYPE_L2_ETHER | > RTE_PTYPE_L3_IPV6 | RTE_PTYPE_L4_UDP; > break; > + case DPAA_PKT_TYPE_IPSEC_IPV4: > + if (*((uintptr_t *)&annot->parse) & DPAA_PARSE_ESP_MASK) > + m->packet_type = RTE_PTYPE_L2_ETHER | > + RTE_PTYPE_L3_IPV4 | RTE_PTYPE_TUNNEL_ESP; > + break; > + case DPAA_PKT_TYPE_IPSEC_IPV6: > + if (*((uintptr_t *)&annot->parse) & DPAA_PARSE_ESP_MASK) > + m->packet_type = RTE_PTYPE_L2_ETHER | > + RTE_PTYPE_L3_IPV6 | RTE_PTYPE_TUNNEL_ESP; > + break; > case DPAA_PKT_TYPE_IPV4_EXT_UDP: > m->packet_type = RTE_PTYPE_L2_ETHER | > RTE_PTYPE_L3_IPV4_EXT | RTE_PTYPE_L4_UDP; Shouldn't 'dpaa_supported_ptypes_get()' needs to be updated to notify host on the capability to report ESP types. > diff --git a/drivers/net/dpaa/dpaa_rxtx.h b/drivers/net/dpaa/dpaa_rxtx.h > index 99e09196e9..b2d7c0f2a3 100644 > --- a/drivers/net/dpaa/dpaa_rxtx.h > +++ b/drivers/net/dpaa/dpaa_rxtx.h > @@ -47,6 +47,7 @@ > * L4R 0xE0 - > * 0x20 - TCP > * 0x40 - UDP > + * 0x60 - IPsec > * 0x80 - SCTP > * L3R 0xEDC4 (in Big Endian) - > * 0x8000 - IPv4 > @@ -63,6 +64,7 @@ > */ > #define DPAA_PARSE_MASK 0x00F044EF00800000 > #define DPAA_PARSE_VLAN_MASK 0x0000000000700000 > +#define DPAA_PARSE_ESP_MASK 0x0008000000000000 > > /* Parsed values (Little Endian) */ > #define DPAA_PKT_TYPE_NONE 0x0000000000000000 > @@ -137,6 +139,10 @@ > (0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_4_6) > #define DPAA_PKT_TYPE_TUNNEL_6_4_TCP \ > (0x0020000000000000 | DPAA_PKT_TYPE_TUNNEL_6_4) > +#define DPAA_PKT_TYPE_IPSEC_IPV4 \ > + (0x0060000000000000 | DPAA_PKT_TYPE_IPV4) > +#define DPAA_PKT_TYPE_IPSEC_IPV6 \ > + (0x0060000000000000 | DPAA_PKT_TYPE_IPV6) > > /* Checksum Errors */ > #define DPAA_PKT_IP_CSUM_ERR 0x0000400200000000