From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42D02A00C2; Fri, 14 Oct 2022 11:40:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37F74410F2; Fri, 14 Oct 2022 11:40:21 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2075.outbound.protection.outlook.com [40.107.92.75]) by mails.dpdk.org (Postfix) with ESMTP id 42FA2410F1 for ; Fri, 14 Oct 2022 11:40:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=atQYyRCQzAzs92OlrZ2QXoy4fh7sF8bcXfgKTINcEEbl+PFuS4hstAn6uzAUkVn3VzFPT4AfoYD+dcbefRyuyZr/CGaZymyz+wzR1MNpuTAeDniH1C8F64bEEskfQCLY5sjuv2ir6sUdZTUKeGEvGynlPIOi9O5E2EbTGAesqiHNu2i2o1JK+J1PqW3J4vHMJjhIAAvzufO3yJM90yUZntaHxHGW6FlRbDbkMOVCXBpeUZPM28vdqaYUlaJiIath0Qv7U9SbPwxxcYkb3rP/0h8SGd482XaV6AZ7aE4162OdLVuI/l3yAxf/Lz2Kf/yedW0LTubgiiKazpHUd+7/QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CJFIrrRgQbnPXH/GR3g427paEi9l0KaT+atIqOH/24c=; b=iZkqJcZG/jkJdwYs4UjyN/roEwxn9qCubOG6MF8DZl32bLbXkQKp5S+afALQTzhoI/Kve/bG/mPSjTlj/1lsL7n5Qad3NcuJ/dr4NjY4CLfgW6qP9KVm44KakHE+U2sraOF0mLxuzEF/nQMNr0ODmHGGdg2KqPiPI6ARKM10bH3cKj8yjLVvrj7GLe4lbCDQGd9/n4jjjdwMnC9WA0QmL6wqRPNtoPjwAZ+TPvLk6niTORwE0HtQTM52IqJqZsTkrFCOOYqVVHrmwD2MRBds3/Aapgytty4TyM9uHaNN5YjwQPIa3d1w/W94J5nf9/nJwVN+G7H0obIG/AbQXhH3QQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CJFIrrRgQbnPXH/GR3g427paEi9l0KaT+atIqOH/24c=; b=JYP+oXneBwBnVSfcMMBaagNV8s8LOXZmSqO1kWz9iMF0ezbcdI0vNfdtAr17ANFzwxzV7xnIaeBltz9a0eXvxjO9v0GMOWp5PYIME5nqMrJC5zvnQW+GuImg/0yGcWUe2yWsVyA9Dr/r5zDTElEeltqw4JdMIGJn+Z96283Y/ec= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by PH8PR12MB7134.namprd12.prod.outlook.com (2603:10b6:510:22d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5723.29; Fri, 14 Oct 2022 09:40:14 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::7900:1b25:bc:104c%9]) with mapi id 15.20.5723.026; Fri, 14 Oct 2022 09:40:14 +0000 Message-ID: Date: Fri, 14 Oct 2022 10:40:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v2] net/nfp: add the feature of RSS based on VXLAN inner layer Content-Language: en-US To: Chaoyong He , dev@dpdk.org Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com References: <1665738548-20974-1-git-send-email-chaoyong.he@corigine.com> From: Ferruh Yigit In-Reply-To: <1665738548-20974-1-git-send-email-chaoyong.he@corigine.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0438.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::11) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|PH8PR12MB7134:EE_ X-MS-Office365-Filtering-Correlation-Id: aa352b22-c748-4fb0-6e40-08daadc81844 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3XfXRNgh2SRGXYV0LINHEKHtByf7kl1TqLRy5NUqrlybuBQ+N+hsdH4bqAQCV+eNthOQd8HW8+xMdm6YidTtpwkRBQdPVb0eJXaPFfJF8G290BjGZfQMFGV55KdRI2n86l/4CAypYC29XJmqEQs4DfAyQt4wTBLUkVGoMw5vQPyziBwZZi/ysh8xBlNsMNVtNAAJv7qS3krdOhAEkU/xROFVoz4UORiRaVgdgUntH/EvDd+8Tb6ebiK+bm251leQf6bZlhSwpN/XzTA6ygYUv0Tqj8pndyvOJZz7JWVCPaY3jVEHfXbmYFy7oz9JAE59G+xIc1tRM/+Q9L2iLefpEhTAyvCDqJQLnU0dzqf5ohVlNWoqfYjel3FVheUj45VUdrm0t1/Fp0yW7NJLcJf5ZaXX4tpQc2vVREXWZh8yVLOs525jbqaBmqERbBapGHIff0cCK2fnMQ3OBgbgIsdXJmIqWZtZcFUP+Z7XzreVSG8Jf2eRrYo6Twj1W+hbi6fT68u1atUckIYln3M5NjvDkaXtYdOFB/34VcM3wHH2Ck0aotJqXgqLqvpf0viomtnBFbHE7XR/0NsmdCiLAU9wUaoeyaVmV/rMt06RDZkrRPJ/I8A/KF4PyNBYtwQ2IYH9ThuFxdjCl8RlaYXs8RZ+/JyTP/tg9Icl+8JrJFzrNCH/XTyfj3HzgyRvEgPEqpzQATvI4RcrooE/DEFDyUa4VJuSjMbz4MSAWqLyzmckwy30Lo10Mv52i5mG8AQfzowDlgFVNAXAuSrQh7UAoJziCxB3LkwbVHGiKoJ1VbY23WU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(451199015)(66556008)(31686004)(83380400001)(316002)(66476007)(8676002)(4326008)(44832011)(6666004)(66946007)(186003)(8936002)(5660300002)(38100700002)(31696002)(36756003)(478600001)(53546011)(2906002)(26005)(6512007)(6486002)(41300700001)(2616005)(6506007)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkNSTmkzZXEvMTJNcEdVRXhEeXcrQXRaSEIyS0pCbThSdzg1c1pudzVIamE5?= =?utf-8?B?Y3JRWjJCZWdLMmkrKzU4Y2s1Qm41M3NkODkxakNrTVl6SVMxMndoNUN1eTRV?= =?utf-8?B?czV3c1BkN2RSMkpuditzV1RWRGVKb0FNclNyelFQQUFjK1V5MmtDYkxIL01t?= =?utf-8?B?d1pOUStMcHBFSDh2THlDWXJ5N1N5bmt2dGc0OGx6bnNpYy9xT3gzMEJTNDd1?= =?utf-8?B?YktYOEprMi9RNVYvd0R4L0gyM3NIZDFkUGI0d1JWSFlINitHQklRL0sydlFE?= =?utf-8?B?K2ZtTXlKS2xDWEhiOGlSNWt4Y1BTR3UvazBYUnFxNlBmVDVMeXZPMDl3NWVJ?= =?utf-8?B?NmsrbWxoSndxSklxQ2w3WkpWQWl3VHZhckJmNjN6MTU2UDZ0TEw5QThwNm5w?= =?utf-8?B?UFdyenEzc2NSdnBKWUZPRXNlZlJ2Mkpjb1VUZG85cWthdkJMblUrWnBNWWI0?= =?utf-8?B?UlRVdGdRdFhIanVGamh3cHNwcGlURmdGVU9sVXBsaklvR1RJaWFJWTZ1ZmVF?= =?utf-8?B?OHdYenZiNXA3a0EyWWdxQlk3c2FMWjBKVVllSDNLM2c2dHAwVXpqT2pjOFhN?= =?utf-8?B?cFZaNTBjdnNJWG1lYWR5b3IzODBWbHFQbXBjYndZOHJWTjV4YlY2SHNKN3Jj?= =?utf-8?B?OHJiaFdpclhZWks4eVp0M2hnMFVueGNnSC9NWkszV0RrYnNJd1ExaHFiMlo1?= =?utf-8?B?R0xOU0FEU3QzWWZsc04yMXRoWC9oT3IwdzlZUVMrbS9Ba0svU21ESXc2bE12?= =?utf-8?B?UzllRGFneEFXZ1ZjZkNJeUNCMkd6clpibVcrRWFvYnc5OFoxZjU3QlhvRytt?= =?utf-8?B?ajNwd2xHM1AvUVJnV3UwYTFYUld6SWRJenc0SmNjQnk2RytHRXd6NThzNjVx?= =?utf-8?B?ZTRaY2NmMHdIM0FQUTlnY0VnVjdyUXFtSHo5WkZJYVkvTTlwTEhkMzF1bnFY?= =?utf-8?B?ZTNMVzlaVWljbTI0RW9MUVlOaUQ3U3BhV3pHRGxOd2FsSS91Z2k0MkVLSFUx?= =?utf-8?B?a0tpY3JzU0hTaHVBNW1nV3BmdS94ZXVrWHRGanM5TDlTQ2dnR3U0aHhaM1Z2?= =?utf-8?B?VnlKT3FlaXd2cWhobVBjUnY4bURyeGlQNHFVY1diQnB0ems2VTZxUHZPa1FR?= =?utf-8?B?Z1JHTVpjMWhteTcrKzVIYnVTQnUrZVdLYVhYbzRQQ25BdEkwSXVSeHkweDZB?= =?utf-8?B?RXoxODhEZXdxbG1ZMkpxM1hIbkFxN1huc2NrbFdSMzF3Qnp2ckJsN29PZEZJ?= =?utf-8?B?VnhFcmtOc3luV3hHV2wzbStzSERGTUl4a0hpZGxDNWl1U05UU21FUUJiSkpZ?= =?utf-8?B?YXVYaFlTSVlHNUl4ZEpjQU1IR2ExZmt2Z3RuMnNtZmlBc2tIS1k0Z1IxYWFl?= =?utf-8?B?N3BIVHJjeDV6RHJEMGZnK1ZEQU1FUUpuZ1hqTFJsSDhOYjN6YjFiV2VoZWVM?= =?utf-8?B?VDN4OXJVSTF5RFVDdmptaFVkMHExSWRaMHNRaWdPdTlVUFRydVg4NlJOQ2pU?= =?utf-8?B?ZDYzaUh3eStkTWRnTmhoSnJTKzF1Vi9mcUlLdGt5Qllna2xTSTJNZU1zWkxy?= =?utf-8?B?bDV4WVhJaDgvOEtNQ3VrY2RGeUVEWEtZV29nOW0wd2RsZVgwR2crNTlMYTYx?= =?utf-8?B?UEx3UnhRb3k3MGpsVldEUnB3VW03WUxaVUw3Nm91ZFVDVDVwSjNvMmlMK3hF?= =?utf-8?B?Y211OUtDNkppSmJGK0Z3QnQ1RTE0V0d3b1V5aldsNHV0a0xHZUZRTFVzalZD?= =?utf-8?B?YUdOQm53TFUzM0tVdTNuVzd4WTlIUlp3cnFlNjFXRHJWS3NKbUREbGpZMUdR?= =?utf-8?B?ajYvaC9JTk9CQURWYXNsRVhValhidVUvcU1jSnJpK1ZNTHVFRFdjcWk3YVU4?= =?utf-8?B?TXV3alNvcDBIMWZaSlJrbUJQOXlyTW9tWVVSbzBNQkw5SVk4VkRLdGo3REVo?= =?utf-8?B?R3NZRG54M0VPdVcrNlV0VjNQbDdkbThEaDQ1VHdvWG1Ca0xvOVVoNDhCZG04?= =?utf-8?B?VVB4RHZlblEyY3pjUnRsYWJHSkN2M3Z3R1FiQkNaazlyV3JzUXRPK0diTnhx?= =?utf-8?B?WTFFTXNLVFhrbmt2clY0ZldRMFZsUDhYbTFrMTFDVEFLQTBaZkhPZ0dCdGJN?= =?utf-8?Q?ClQDtZXO22Vbtd83UL9Y1NSMP?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa352b22-c748-4fb0-6e40-08daadc81844 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2022 09:40:14.0422 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1p0vEgBMIrI2dVUWlOumi8YfeX1RU4MKJj+U9OTVNbrn505dVu+JDryUgJ4Vltk+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7134 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/14/2022 10:09 AM, Chaoyong He wrote: > diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c > index e131021..d938e01 100644 > --- a/drivers/net/nfp/nfp_ethdev.c > +++ b/drivers/net/nfp/nfp_ethdev.c > @@ -33,7 +33,6 @@ > #include "nfpcore/nfp_nsp.h" > > #include "nfp_common.h" > -#include "nfp_ctrl.h" > #include "nfp_rxtx.h" > #include "nfp_logs.h" > #include "nfp_cpp_bridge.h" > @@ -138,6 +137,10 @@ > > update |= NFP_NET_CFG_UPDATE_GEN | NFP_NET_CFG_UPDATE_RING; > > + /* Enable vxlan */ > + new_ctrl |= NFP_NET_CFG_CTRL_VXLAN; > + update |= NFP_NET_CFG_UPDATE_VXLAN; > + > if (hw->cap & NFP_NET_CFG_CTRL_RINGCFG) > new_ctrl |= NFP_NET_CFG_CTRL_RINGCFG; Hi Chaoyong, Thanks for the update. Although practically you don't need to include 'nfp_ctrl.h' since it is included by 'nfp_common.h', 'nfp_ethdev.c' uses symbols from 'nfp_ctrl.h'. What do you think to explicitly include a header when source file uses symbols from that header as a principal? This helps to document what is required externally for source file clearly, also protects against changes, like you may move 'nfp_ctrl.h' include out of 'nfp_common.h' in the future. According above, would you be OK to include 'nfp_ctrl.h' in 'nfp_common.h' (as already done), but not remove 'nfp_ctrl.h' from files that use symbols from it?