From: Ilya Maximets <i.maximets@samsung.com>
To: Zhirun Yan <zhirun.yan@intel.com>, dev@dpdk.org, qi.z.zhang@intel.com
Cc: haiyue.wang@intel.com
Subject: Re: [dpdk-dev] [v1] net/i40e: fix RX/TX setup when restart port
Date: Wed, 28 Nov 2018 12:32:13 +0300 [thread overview]
Message-ID: <f316acd7-9862-2ab3-1e09-85e3e9596f2c@samsung.com> (raw)
In-Reply-To: <20181128165152.78676-1-zhirun.yan@intel.com>
On 28.11.2018 19:51, Zhirun Yan wrote:
> Before this patch, there are two functions that will clear RX/TX queues
> number: rte_eth_dev_close() and i40e_dev_free_queues(). But if also
> i40e_dev_free_queues() clear it, RX/TX queues will not set up correctly
> when restart port.
According to DPDK API device could not be restarted after rte_eth_dev_close:
"Close a stopped Ethernet device. The device cannot be restarted!"
http://doc.dpdk.org/api/rte__ethdev_8h.html#a93eeb672a2f9cd18e338aad10c77687c
You should not close the device if you're willing to use it later.
If you really want to close it, you'll need to detach it and attach
back when needed.
>
> Fixes: 6b4537128394 ("i40e: free queue memory when closing")
>
> Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> index e1152ff0e..cc953ad58 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_rx_queue_release(dev->data->rx_queues[i]);
> dev->data->rx_queues[i] = NULL;
> }
> - dev->data->nb_rx_queues = 0;
>
> for (i = 0; i < dev->data->nb_tx_queues; i++) {
> if (!dev->data->tx_queues[i])
> @@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)
> i40e_dev_tx_queue_release(dev->data->tx_queues[i]);
> dev->data->tx_queues[i] = NULL;
> }
> - dev->data->nb_tx_queues = 0;
> }
>
> #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC
>
next prev parent reply other threads:[~2018-11-28 9:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:51 [dpdk-dev] [PATCH v1] " Zhirun Yan
[not found] ` <CGME20181128093221eucas1p119d9c4741bb612ae7fc5700c64e8595a@eucas1p1.samsung.com>
2018-11-28 9:32 ` Ilya Maximets [this message]
2018-11-30 6:52 ` [dpdk-dev] [v1] " Yan, Zhirun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f316acd7-9862-2ab3-1e09-85e3e9596f2c@samsung.com \
--to=i.maximets@samsung.com \
--cc=dev@dpdk.org \
--cc=haiyue.wang@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).