From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id C41CE58D6 for ; Fri, 26 Aug 2016 09:30:15 +0200 (CEST) Received: from lfbn-1-8252-96.w81-254.abo.wanadoo.fr ([81.254.151.96] helo=[192.168.1.13]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1bdBdT-0006VO-IX; Fri, 26 Aug 2016 09:33:07 +0200 To: Xiao Wang , jing.d.chen@intel.com References: <1472147299-2376-1-git-send-email-xiao.w.wang@intel.com> <1472147299-2376-5-git-send-email-xiao.w.wang@intel.com> Cc: dev@dpdk.org From: Olivier Matz Message-ID: Date: Fri, 26 Aug 2016 09:30:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1472147299-2376-5-git-send-email-xiao.w.wang@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 4/5] net/ixgbe: implement new Rx checksum flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 07:30:15 -0000 Hi Xiao, On 08/25/2016 07:48 PM, Xiao Wang wrote: > Add CKSUM_GOOD flag to distinguish a good checksum from an unknown one. > > Signed-off-by: Xiao Wang > --- > drivers/net/ixgbe/ixgbe_rxtx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c > index 8a306b0..d2dc82a 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1345,7 +1345,9 @@ rx_desc_error_to_pkt_flags(uint32_t rx_status) > * Bit 30: L4I, L4I integrity error > */ > static uint64_t error_to_pkt_flags_map[4] = { > - 0, PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_GOOD, > + PKT_RX_IP_CKSUM_GOOD | PKT_RX_L4_CKSUM_BAD, > + PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_GOOD, > PKT_RX_IP_CKSUM_BAD | PKT_RX_L4_CKSUM_BAD > }; > pkt_flags = error_to_pkt_flags_map[(rx_status >> > I think this would somehow conflict with the patch adding the support of Rx checksum offload in vector receive function: http://dpdk.org/dev/patchwork/patch/14630/ Depending on which one is pushed first, the second one would need to be reworked. Olivier