From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94D04A0A0C; Thu, 15 Jul 2021 18:04:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 273584014D; Thu, 15 Jul 2021 18:04:40 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 7ED5F40143 for <dev@dpdk.org>; Thu, 15 Jul 2021 18:04:37 +0200 (CEST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4GQfDv066gzXtQP; Thu, 15 Jul 2021 23:58:55 +0800 (CST) Received: from dggpeml500024.china.huawei.com (7.185.36.10) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 00:04:34 +0800 Received: from [10.40.190.165] (10.40.190.165) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 16 Jul 2021 00:04:34 +0800 From: fengchengwen <fengchengwen@huawei.com> To: <thomas@monjalon.net>, <ferruh.yigit@intel.com>, <bruce.richardson@intel.com>, <jerinj@marvell.com>, <jerinjacobk@gmail.com>, <andrew.rybchenko@oktetlabs.ru> CC: <dev@dpdk.org>, <mb@smartsharesystems.com>, <nipun.gupta@nxp.com>, <hemant.agrawal@nxp.com>, <maxime.coquelin@redhat.com>, <honnappa.nagarahalli@arm.com>, <david.marchand@redhat.com>, <sburla@marvell.com>, <pkapoor@marvell.com>, <konstantin.ananyev@intel.com> References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <1626363661-51103-1-git-send-email-fengchengwen@huawei.com> Message-ID: <f3300cd6-573a-a90c-f2f9-35a875405de0@huawei.com> Date: Fri, 16 Jul 2021 00:04:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <1626363661-51103-1-git-send-email-fengchengwen@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.40.190.165] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v4] dmadev: introduce DMA device library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> @burce, jerin Some unmodified review comments are returned here: 1. COMMENT: > + memset(dmadev_shared_data->data, 0, > + sizeof(dmadev_shared_data->data)); I believe all memzones are zero on allocation anyway, so this memset is unecessary and can be dropped. REPLY: I didn't find a comment to clear with this function. 2. COMMENT: > + * @see struct rte_dmadev_info::dev_capa > + */ Drop this flag as unnecessary. All devices either always provide ordering guarantee - in which case it's a no-op - or else support the flag. REPLY: I prefer define it, it could let user know whether support fence. 3. COMMENT: I would suggest v4 to split the patch like (so that we can review and ack each patch) 1) Only public header file with Doxygen inclusion, (There is a lot of Doxygen syntax issue in the patch) 2) 1 or more patches for implementation. REPLY: the V4 still one patch and with doxyen files, It's better now for just one patch of header file and implementation. Later I will push doxyen file patch and skelton file patch. 4. COMMENT: > + * @see RTE_DMA_DEV_TO_MEM > + * @see RTE_DMA_DEV_TO_DEV Since we can set of only one direction per vchan . Should be we make it as enum to make it clear. REPLY: May some devices support it. I think it's OK for future use. 5. COMMENT: > +__rte_experimental > +int > +rte_dmadev_vchan_release(uint16_t dev_id, uint16_t vchan); I would like to remove this to align with other device class in DPDK and use configure and start again if there change in vchannel setup/ REPLY: I think we could have dynamic reconfig vchan without stop device ability. 6. COMMENT: > + > +#define RTE_DMADEV_ALL_VCHAN 0xFFFFu RTE_DMADEV_VCHAN_ALL ?? REPLY: I don't like reserved a fix length queue stats in 'struct rte_eth_stats', which may counter the RTE_ETHDEV_QUEUE_STAT_CNTRS too short problem. So here I define the API could get one or ALL vchans stats. 7. COMMENT: > +rte_dmadev_copy_sg(uint16_t dev_id, uint16_t vchan, const struct rte_dma_sg *sg, > + uint64_t flags) In order to avoid population of rte_dma_sg in stack (as it is fastpath), I would like to change the API as rte_dmadev_copy_sg(uint16_t dev_id, uint16_t vchan, struct rte_dma_sge *src, struct rte_dma_sge *dst, uint16_t nb_src, uint16_t nb_dst, uint64_t flags) REPLY: Too many (7) parameters if it separates. I prefer define a struct wrap it. 8. COMMENT: change RTE_LOG_REGISTER(rte_dmadev_logtype, lib.dmadev, INFO); to RTE_LOG_REGISTER_DEFAULT, and change rte_dmadev_logtype to logtype. REPLY: Our CI version still don't support RTE_LOG_REGISTER_DEFAULT (have not sync newest version), I think it could fix in next version or patch. and because RTE_LOG_REGISTER define the rte_dmadev_logtype as a un-static variable, if we change to logtype, there maybe namespace conflict, so I think it's ok to retain the original variables. thanks. [snip] On 2021/7/15 23:41, Chengwen Feng wrote: > This patch introduce 'dmadevice' which is a generic type of DMA > device. > > The APIs of dmadev library exposes some generic operations which can > enable configuration and I/O with the DMA devices. > > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com> > --- > v4: > * replace xxx_complete_fails with xxx_completed_status. > * add SILENT capability, also a silent_mode in rte_dmadev_conf. > * add op_flag_llc for performance. > * rename dmadev_xxx_t to rte_dmadev_xxx_t to avoid namespace conflict. > * delete filed 'enqueued_count' from rte_dmadev_stats. > * make rte_dmadev hold 'dev_private' filed. > * add RTE_DMA_STATUS_NOT_ATTEMPED status code. > * rename RTE_DMA_STATUS_ACTIVE_DROP to RTE_DMA_STATUS_USER_ABORT. > * rename rte_dma_sg(e) to rte_dmadev_sg(e) to make sure all struct > prefix with rte_dmadev. > * put the comment afterwards. > * fix some doxgen problem. > * delete macro RTE_DMADEV_VALID_DEV_ID_OR_RET and > RTE_DMADEV_PTR_OR_ERR_RET. > * replace strlcpy with rte_strscpy. > * other minor modifications from review comment. > v3: [snip]