From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43D1241EB2; Thu, 16 Mar 2023 18:36:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F42540DF6; Thu, 16 Mar 2023 18:36:34 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2067.outbound.protection.outlook.com [40.107.237.67]) by mails.dpdk.org (Postfix) with ESMTP id 522EB40DDC for <dev@dpdk.org>; Thu, 16 Mar 2023 18:36:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NZO7Rzsy91FIcFQPvShwH9PPXT2FQcSxTOXxJTwtrZWpQInpm6KtwmdW7UywB2XFxxaJ0bX2zkdavnviMHlvNIc9w8qQX4VufM6My4JId61XUUtbIag/cBF0YZm1mimwPqzPTSqjMI+XF8GgTQq0jNn2gnhb4CuUFnfpOikvfybqiD7y/s5LOuLTS1tF1+T2QiUDUGF7KvS3k96DvKjxZZMgjQ6cAdj38DzlmA7fcKJR9wbo8/4g0YtsoX4hwHRMWG+VoDjD3qldVytONS2kKFyQNIiDJn5TBT9QSl78OCXQmxXUSI4FTy3e/gdhbzALvnFkl5oic3ABVNYtLME7fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HpRF47kxBphfZDm7lUdZepo88iAyjhHojX24mwzYrEU=; b=Hz5J04NafDdZQkPXwV4TQf3tYOsqVyApPwOEJ4wHWbSYjkrJl1YVI5crKnZbrEAIQ/GFMtfDjhk13jdY82w05YWJygvhlmVGd4IxT2GDaaUvBnXWQZpaOtjZOxIVHgw0Khju4txNHTP5lKC1OURTDamfa9tj99HtKWmYP1BlXOimFNhAhyALC8O023MquXHGtcmtDd2Gb7Rdk3leqmeSwrgn9ufIYIO82ONLUNVSU4pTpvZ6o95nW+m0DCOZwr+I5MGcig3vhjv3R4xrUSnBd863J6ijrrRE4aYMHndfM7uSW9WiL4lurzcEqQojPniOPArImrOqJgs6qWcBvNwIsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpRF47kxBphfZDm7lUdZepo88iAyjhHojX24mwzYrEU=; b=lSyfKerr4fzCPXZKtpoJnbCFV9Bw95lGg7d89TFxUSa73WfS3KUirOx1Lx3g0wEae4LiRVqik91Tr8m6oq0fowz4HWQcQJahnMiiKvYdKQaox+vKexTvP8fMAxix431TTqcmj/Qf8vXGto/TpKzO12oh1FLzBf6taH290+Ms8Tw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by LV2PR12MB5917.namprd12.prod.outlook.com (2603:10b6:408:175::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.31; Thu, 16 Mar 2023 17:36:30 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%5]) with mapi id 15.20.6178.026; Thu, 16 Mar 2023 17:36:30 +0000 Message-ID: <f33d0945-8da7-468e-2ded-bf80ebcf2fbb@amd.com> Date: Thu, 16 Mar 2023 17:36:25 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v4 0/2] Fix testpmd interrupt regression Content-Language: en-US To: Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org> Cc: dev@dpdk.org, David Marchand <david.marchand@redhat.com>, Pier Damouny <pdamouny@nvidia.com>, olivier.matz@6wind.com References: <20230313171905.67720-1-stephen@networkplumber.org> <20230316083104.3872a538@hermes.local> <aa357d90-7a02-b961-44d6-927ecbc0e91b@amd.com> <3151640.5fSG56mABF@thomas> From: Ferruh Yigit <ferruh.yigit@amd.com> In-Reply-To: <3151640.5fSG56mABF@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0311.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|LV2PR12MB5917:EE_ X-MS-Office365-Filtering-Correlation-Id: 509f4bbe-6527-4389-c955-08db2644fa56 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: neiUHdZNNzixQyRPl561Wyf+2UvoZI5gfftUjh1Y3A19ZL1kvkbBHnAOdAFFSCGUPQbsb2cNHD7VJvko1OKjnZ9M+S/IaJhg18l/jLvWBMpxzAO+8XtiO7mru+auwGbjHLztai30pdb9haAxtIEHDpQWTdTnoaZN0JJ8nGttwVOJ8DrQK0+Thtels5TJnepCR96qqjx5Ndte8ZJj4JxUi+4XU10LTnREFItvdCwMQM6DulKTKD+IablVUyttqzptN4A4YCa5u1jDn4ddCBZFivth3V55HrhAl2jvGpufunjQUQYPBaLNMEpPKbIrZVJrZrbWwNESYlMDudbZKrjSfdNFjDe0RoWheIb2Zg1lncAFEiopmDVSnlHrReEdrGy4O9D8cnqnNHppbQ/cGDWzE2lUwrI8abwb/HLlqJu0CXsFOjDqTtdDtNso2SjEdABCrQJ2x7JoOm39yrXaP++UhSiGtjh+qi158G5hFvDBfisGgLl8m1Nk4MRo7LNfPUTO0ddHFCOzr0lyt7N0Z+poU5jj7Fd7pMU3mCoYhrBlAgQI7KixM3THtITflb/Qk5RX/Q7QqoLXqp9cEMCMIy1QBRDeEpjSm93FhSEkFk3ln3ANuPC/6xG0SAkbjsID1fvGeTs7xaopMyQpCATzTXDzAUKXFVPEgfWrMQGSywnPZDAzAznm5lcOy6LDnh5YLe+stfhiQ2stmxB4wWmE22BdIw4KFhELaeCXKZw8qkDmnrc= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(346002)(39860400002)(396003)(376002)(366004)(136003)(451199018)(66946007)(4326008)(31686004)(41300700001)(83380400001)(110136005)(316002)(38100700002)(8936002)(54906003)(66476007)(66556008)(8676002)(5660300002)(478600001)(36756003)(44832011)(31696002)(86362001)(53546011)(26005)(6506007)(6512007)(6486002)(966005)(2616005)(2906002)(186003)(6666004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXYvNEdJRE8ySnA0akkyQnNIR3QyaFRpNXRKdE5kMC85b2dGa29mMW8xU0RL?= =?utf-8?B?ZVpNNHgrQTlqdlJFVkNkRElFbzBVbzV2eVpHVTUrbUlHbXZ2MjhlZEdJSm1D?= =?utf-8?B?YXlmRjNWN24xL09SelNnVmlzaDdORmszQjZ0Qml3SFpUUUxBa1FmdGJLQW04?= =?utf-8?B?RWlFeUk3M0xqdy9nNTJSYm55U0gza082U1JaOEowdkM3Y2tnZHpzaEFTbita?= =?utf-8?B?bjE4Tk1OL2hmdHJnNlhLdi9DYlVDYzZUdDZESFQ0ODRZd1NxRmtVMXhpdHJP?= =?utf-8?B?Y0ZnM1pJYlY2S0RNaHp4T1doYUNsNUFBR0VBOXZiaXRneEF4b0pvOVY3d0Rw?= =?utf-8?B?QU1BRzEyeFAxN1o0WUJxNkhtZ2VOT1hkZnYyaHAwdUROdktrZldqeGYxU21T?= =?utf-8?B?VlR5YkJUejBOWmNGQ0hmK0R0T0VjNEZiME9UL2I4bGtRZGhIMXk3b0RWL1V3?= =?utf-8?B?MGpaUXh4SDkvdHpLREI1RXVoRzMvR0RQcHNCOStTQjdJTmV6Z2dCck01cUpQ?= =?utf-8?B?d0Q1UFBERnJUWGoraThob2ZSV2poYVc3U244R0p6UmF4YzlKY2xBRVA3dDJw?= =?utf-8?B?UytnUE1EUk5mYmhvZHIyT1FGSjBkamRPbWxPUTFIZmJXZ3lQR0laN3lydDlO?= =?utf-8?B?cE9RK0xUMCtON2VadnFnY3prTVN4VFZVQ2lzcDM2VTJPVnJnbFhFVis5VEo1?= =?utf-8?B?WFlmdmNGb2QzZGVpOEExbGU0QUJ4OG83aUxEZE9BT1VVdjlWanVjQ1JFdDQ0?= =?utf-8?B?NTRrcXVjMThLVENSb0JHdURBZktVMVNlVGpHUUY2ZE8vTjVEZk9sdnd6ZFFa?= =?utf-8?B?Z3gwZG9XcmJ2Qmswckd1TE1GeS9XTC9yemlYSHFIakhjRHNEeXFpeXNtQnN2?= =?utf-8?B?cEhROHFYVVcxT1o2SWVYdEExOHBXNDVIRVBwcTliZTlhTDgzMXNoZDZVV2hk?= =?utf-8?B?bWZ0WGx1U3RwNEx2S3dIQmFDR3djZFo0OEdoNTRhVVJRVTk5VG9waHM5N3VK?= =?utf-8?B?RWNQWk10T1ZTNHh1U1pSNUEraE5TWW9wa0l2cHl4ZGE3VmlIcklMQ3FXbkZH?= =?utf-8?B?aGZyVzJBL216UjNaZDM4WjQrZE5CbkdteEdmVFZQOHRJb2N1Vm5Xb2QrTzFw?= =?utf-8?B?VEJxU3hjK2ZCajU0MThjL21iYTd5bXRYRGxybGNxSWtMRVdBREc3dlp3MTNC?= =?utf-8?B?SlhvYzhDM3hBZnJxZENjbndCT0orZVdwbGVvUFFBdUVJVklSbU16ZnNLanlq?= =?utf-8?B?UStMc21IbWdPOFpNUkFqQ0U5c05xSWtPVG5tZ1hVYXFpRTZYbXJsd0RaVzY3?= =?utf-8?B?MHo5ZExpYTZkd1VmWUZ6akVQUHJvY25rRXJtNHdaTWV5V0twOFJ3eTBKc0ZJ?= =?utf-8?B?VU44VTFDNmp4c2pHeXZEWGZYY21CNFAzVjVuL3dVS20rREtaaWRScGxGcm5T?= =?utf-8?B?WDRTa2ZQYjYrNGFvcXhsak9rOWl6aXV2TFZ4eENhdURaSU1vSWVWWklaYS9T?= =?utf-8?B?QWZ3OXZDUEdjVmVLZUFnTlNHSzhrZmQrUlhZL1JUdkZ3bzZhd1pCQ2ZXL2R0?= =?utf-8?B?b3d0U3RVdFVDU053c1NQS2Z5S2pjUkdyVXZ6Y3NlQ0xmeHZ3VTdaZUc1Ylpi?= =?utf-8?B?Q2VJR1p1TjdRNzh1NzVMNjE5bldzUU12TXUvdWlKbmlZU0RzS1p2RE1ud21H?= =?utf-8?B?L3lSaEJUM1JKS3pFU0pJY0hOSjRMNGN0TzI3MEpYTXpPUjM2YkpXUk5uczFT?= =?utf-8?B?NkRJWm93NnNKTnIwWmUrV0tnZXdrOEo2eHVWTW5JekorTm10NTZjREhjdW01?= =?utf-8?B?TVVXSEpickd2N0wwY2hlRmlvRzlqZVJPdDF1bUJsSzAvRjVZZ1lqbHNSUXMv?= =?utf-8?B?UUk2RVJYY295SlpRUEpjS01HSGVWNFBXOEtMQjFXbzczbFRCUFViQ1VZVXQy?= =?utf-8?B?TUU2ZWFRWC9vc2hpMzVVVVl6ejhiL0U0NGRTU3diQjdBRFhkSUxYRHRsRC9Y?= =?utf-8?B?UUdHR2FBNWhKRUJoTHhyWm5Sa1NKVWY2dHhKV0lqbmRTWFVTV0NzdVlOR3I3?= =?utf-8?B?NWRXaThSRXBiQzhtdm5XT0NlS0dReFhSeGtCcGlsdnhJSjNYT1lSSzlFeXF2?= =?utf-8?Q?USAYDctku5Po6esGizrikhSnF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 509f4bbe-6527-4389-c955-08db2644fa56 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Mar 2023 17:36:30.4867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ocRLMbT7EDOAOIR7MeQ6iskW6v+uFqgpVVh2ejMgbfQtp5ultW90kDrBOh0o93aq X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV2PR12MB5917 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 3/16/2023 5:05 PM, Thomas Monjalon wrote: > 16/03/2023 18:01, Ferruh Yigit: >> On 3/16/2023 3:31 PM, Stephen Hemminger wrote: >>> On Thu, 16 Mar 2023 12:20:41 +0000 >>> Ferruh Yigit <ferruh.yigit@amd.com> wrote: >>> >>>> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: >>>>> Resolve issues from using control-C in testpmd. >>>>> Fixes regression from recent change to use cmdline_poll(). >>>>> >>>>> v4 - drop sig_atomic_t. Not required requires changes on >>>>> some platforms. >>>>> >>>>> Stephen Hemminger (2): >>>>> testpmd: go back to using cmdline_interact >>>>> testpmd: enable interrupt in interactive mode >>>>> >>>>> app/test-pmd/cmdline.c | 27 ++++++++++++++------------- >>>>> app/test-pmd/testpmd.c | 11 +++++++++++ >>>>> lib/cmdline/cmdline.h | 10 ++++++++++ >>>>> lib/cmdline/cmdline_os_unix.c | 8 +++++++- >>>>> lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- >>>>> lib/cmdline/cmdline_private.h | 2 +- >>>>> lib/cmdline/version.map | 3 +++ >>>>> 7 files changed, 62 insertions(+), 17 deletions(-) >>>>> >>>> >>>> This solution is adding new cmdline API for -rc3 and there are some >>>> testpmd changes, >>>> can it be possible to have a simple workaround specific to window for >>>> this release and get this set for next release? >>> >>> >>> Not really. cmdline_poll() is broken in several ways. >>> Don't want to fix it or use it. >> >> What about to revert the original fix [^1] in this release and get a new >> version of it at early next release? >> >> @Thomas, what do you think? I think better to decide before -rc3. > > We should not add risky changes at this stage. > Also I would prefer to see a review from Olivier, the cmdline maintainer. > > The reason of this breakage was a cleanup. > I think it is more reasonnable to revert. > > Sent a revert patch [^1], and assigned to Thomas. [^1] https://patches.dpdk.org/project/dpdk/patch/20230316172739.77933-1-ferruh.yigit@amd.com/