From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id A4DCCFBEC
 for <dev@dpdk.org>; Tue, 20 Dec 2016 18:23:26 +0100 (CET)
Received: from orsmga005.jf.intel.com ([10.7.209.41])
 by orsmga104.jf.intel.com with ESMTP; 20 Dec 2016 09:23:25 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,379,1477983600"; d="scan'208";a="44693563"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29])
 ([10.237.220.29])
 by orsmga005.jf.intel.com with ESMTP; 20 Dec 2016 09:23:24 -0800
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
References: <1480675394-59179-1-git-send-email-wei.zhao1@intel.com>
 <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>
Cc: wenzhuo.lu@intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <f3445bf4-2ae8-0d01-1649-b14431fc7c36@intel.com>
Date: Tue, 20 Dec 2016 17:23:23 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 11/18] net/ixgbe: parse n-tuple filter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Dec 2016 17:23:27 -0000

On 12/2/2016 10:43 AM, Wei Zhao wrote:
> From: wei zhao1 <wei.zhao1@intel.com>
> 
> Add rule validate function and check if the rule is a n-tuple rule,
> and get the n-tuple info.
> 
> Signed-off-by: wei zhao1 <wei.zhao1@intel.com>
> Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 349 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 349 insertions(+)

<...>

> + */
> +static enum rte_flow_error_type
> +cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
> +			 const struct rte_flow_item pattern[],
> +			 const struct rte_flow_action actions[],
> +			 struct rte_eth_ntuple_filter *filter)
> +{

<...>

> +
> +	return 0;

This gives build error [1] with ICC, there are a few same usage, return
type is enum but returning an int.

[1]
/tmp/dpdk_maintain/ixgbe_flow/dpdk/drivers/net/ixgbe/ixgbe_ethdev.c(8432):
error #188: enumerated type mixed with another type
        return 0;
               ^