* [dpdk-dev] [PATCH] app/testpmd: fix qinq strip display option
@ 2018-10-26 12:40 Jerin Jacob
2018-10-26 14:34 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Jerin Jacob @ 2018-10-26 12:40 UTC (permalink / raw)
To: dev, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: thomas, Jacob, Jerin, shahafs, stable
Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
Cc: shahafs@mellanox.com
Cc: stable@dpdk.org
Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 169662321..fb79dd0be 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -583,7 +583,7 @@ port_offload_cap_display(portid_t port_id)
if (dev_info.rx_offload_capa & DEV_RX_OFFLOAD_QINQ_STRIP) {
printf("Double VLANs stripped: ");
if (ports[port_id].dev_conf.rxmode.offloads &
- DEV_RX_OFFLOAD_VLAN_EXTEND)
+ DEV_RX_OFFLOAD_QINQ_STRIP)
printf("on\n");
else
printf("off\n");
--
2.19.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix qinq strip display option
2018-10-26 12:40 [dpdk-dev] [PATCH] app/testpmd: fix qinq strip display option Jerin Jacob
@ 2018-10-26 14:34 ` Ferruh Yigit
2018-10-26 15:11 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-26 14:34 UTC (permalink / raw)
To: Jerin Jacob, dev, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: thomas, Jacob, Jerin, shahafs, stable
On 10/26/2018 1:40 PM, Jerin Jacob wrote:
> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND ...
>
> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>
> Cc: shahafs@mellanox.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix qinq strip display option
2018-10-26 14:34 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
@ 2018-10-26 15:11 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-10-26 15:11 UTC (permalink / raw)
To: Jerin Jacob, dev, Wenzhuo Lu, Jingjing Wu, Bernard Iremonger
Cc: thomas, Jacob, Jerin, shahafs, stable
On 10/26/2018 3:34 PM, Ferruh Yigit wrote:
> On 10/26/2018 1:40 PM, Jerin Jacob wrote:
>> Fix a typo on DEV_RX_OFFLOAD_QINQ_STRIP selection.
>
> I think this is not typo but confusion caused by DEV_RX_OFFLOAD_VLAN_EXTEND ...
>
>>
>> Fixes: 0074d02fca21 ("app/testpmd: convert to new Rx offloads API")
>>
>> Cc: shahafs@mellanox.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-26 15:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 12:40 [dpdk-dev] [PATCH] app/testpmd: fix qinq strip display option Jerin Jacob
2018-10-26 14:34 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-10-26 15:11 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).