From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C0A3A052A; Tue, 2 Feb 2021 12:38:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A35B240272; Tue, 2 Feb 2021 12:38:57 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 1E34D240270 for ; Tue, 2 Feb 2021 12:38:55 +0100 (CET) IronPort-SDR: NHmEsRqD+XzyWIkg5FT8DReaOpG4V0Cwss/xqYtENkYBH1by6q8FM4jGFdZi/UdKccC4EwhmFw Bw6yVtP5lyAg== X-IronPort-AV: E=McAfee;i="6000,8403,9882"; a="180063116" X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="180063116" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 03:38:55 -0800 IronPort-SDR: 6O+qZ0Zwpp/ZAe6aOhh2W+vCX7pMggIBq3n5LS4Lj5ydLDCh4uOAyiJ3nxhlx3OZ4pnuZmIdQg zcG+0gbyac7w== X-IronPort-AV: E=Sophos;i="5.79,394,1602572400"; d="scan'208";a="391422875" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 03:38:54 -0800 To: Hemant Agrawal , dev@dpdk.org References: <20210120142723.14090-1-hemant.agrawal@nxp.com> <20210120142723.14090-8-hemant.agrawal@nxp.com> From: Ferruh Yigit Message-ID: Date: Tue, 2 Feb 2021 11:38:52 +0000 MIME-Version: 1.0 In-Reply-To: <20210120142723.14090-8-hemant.agrawal@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 7/7] net/dpaa2: add support to configure dpdmux max Rx frame len X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/20/2021 2:27 PM, Hemant Agrawal wrote: > This patch introduce a new pmd api, which can help the applications > to configure the max framelen for a given dpdmux interface > > Signed-off-by: Hemant Agrawal <...> > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice > + * > + * demultiplex interface max rx frame length configure > + * > + * @param dpdmux_id > + * ID of the DPDMUX MC object. > + * @param max_rx_frame_len > + * maximum receive frame length (will be checked to be minimux of all dpnis) > + * > + */ > +__rte_experimental > +int > +rte_pmd_dpaa2_mux_rx_frame_len(uint32_t dpdmux_id, uint16_t max_rx_frame_len); > + PMD specific APIs are not good for portability, and I think better to reduce them as much as possible. Can't this new parameter provided as devarg, instead of a new PMD API?